Make SpannerChangeStreamPlacementTableIT against Spanner prod. - #36071
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @changliiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request modifies an existing integration test for Spanner change streams to ensure it runs against the production Spanner environment. This change streamlines the test setup by removing hardcoded host configurations, allowing the test to leverage default or environment-specific production settings.
Highlights
- Spanner Integration Test Environment: The SpannerChangeStreamPlacementTableIT integration test has been updated to connect to the Spanner production environment by default, removing the previous explicit configuration for a staging/sandbox host.
- Test Environment Configuration: The IntegrationTestEnv class is now instantiated using its default constructor, simplifying the setup for the Spanner change stream placement table integration test.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Assigning reviewers: R: @m-trieu for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @m-trieu |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @ahmedabu98 for label java. Available commands:
|
|
One thing I notice is that all the tests are marked "skipped": https://develocity.apache.org/s/gjxhhlak3pi2i/tests/overview?class=org.apache.beam.sdk.io.gcp.spanner.changestreams.it.SpannerChangeStreamPlacementTableIT |
|
Reminder, please take a look at this pr: @ahmedabu98 |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
|
|
Reminder, please take a look at this pr: @robertwb |
@changliiu could you respond to this comment please? Thanks! |
hi I'll remove this once the change stream read API is flag flipped. Then these tests will not be skipped |
|
Reminder, please take a look at this pr: @robertwb |
3 participants
SpannerChangeStreamPlacementTableIT integration test now is against Spanner prod environment.