Upgrade cryptography dep to latest to resolve CVE-2024-12797 - #36110
Upgrade cryptography dep to latest to resolve CVE-2024-12797#36110kennknowles wants to merge 1 commit into
Conversation
|
R: @liferoad |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @kennknowles, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates a core Python dependency, cryptography, to its latest version. This change is primarily aimed at resolving a reported security vulnerability, CVE-2024-12797, and tidying up dependency requirements, even if the issue might already be implicitly resolved in container builds.
Highlights
- Security Update: The cryptography dependency has been upgraded to version 45.0.7 to address CVE-2024-12797, mitigating a reported security vulnerability.
- Dependency Management: The setup.py file in the Python SDKs has been updated to reflect the new minimum version requirement for the cryptography package.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
setup.py should not affect vulnerability scanning, otherwise it would mean our republish workflow won't help for vulnerability alerts. checked internal logs. The vulnerability actually came from gcloud cli: |
|
Ah, gotcha. I did not find those logs. That is useful. I will close this because it caused everything to go red anyhow. But the version of cryptography here really does link a bad ssl. |
3 participants
This is already resolved in our containers requirements, but I saw a scanner result that complained. This might remove the "false positive". I re-ran the generate-requirements and it did not change the containers. Anyhow this is at least probably tidying.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.