[Prism] Disable combiner lifting for TriggerAlways - #36146
Merged
Conversation
shunping
marked this pull request as ready for review
September 15, 2025 03:07
shunping
changed the title
shunping
changed the title
Contributor
|
Assigning reviewers: R: @jrmccluskey for label go. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
lostluck
approved these changes
Sep 15, 2025
lostluck
left a comment
lostluck
left a comment
Contributor
There was a problem hiding this comment.
Great find. TriggerAlways can be viewed as Repeated(ElementCount=1) IIRC. I suppose the flakiness of the test is what made me miss it, as it spuriously passed.
Collaborator
Author
Brilliant! That's a good explanation of why it also failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as TriggerElementCount, TriggerAlways does not work well with combiner lifting. Therefore, we disable if there is such a trigger in the window strategy.
With this fix, the TriggerAlways integration test passed.
fixes #36145