FirestoreV1 - Fix output timestamp to be based on input window, not walltime.

[stankiewicz]

Fixes #27138

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @stankiewicz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the FirestoreV1 connector where the timestamps associated with write operation outputs were incorrectly derived from the current walltime. By modifying the relevant write functions, the system now correctly uses the maximum timestamp of the input BoundedWindow for outputting write summaries and failures. This change ensures that the event time semantics are properly maintained throughout the data processing pipeline, leading to more accurate and consistent data handling.

Highlights

• Timestamp Correction: The output timestamp for FirestoreV1 write operations has been corrected to be based on the input BoundedWindow's maximum timestamp, rather than the system's walltime.
• Method Signature Update: The Instant timestamp parameter has been removed from the handleWriteFailures and handleWriteSummary method signatures in BaseBatchWriteFn and its implementing classes.
• Output Context Adjustment: Calls to context.output within the write success and failure handlers now explicitly use tuple.getValue().maxTimestamp() to ensure the correct event time is propagated.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[stankiewicz]

R: @kennknowles

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[kennknowles]

Removing the use of "current time" makes sense, and fixes an existing bug. But at a very quick glance, it seems like the code maybe would benefit from a timestamp policy. Potentially leaving in the timestamp parameter could make sense, since the effective timestamp would be computed by the caller.

Up to you, and it can always be changed later if it matters. Approving.