diff --git a/sdks/go/container/tools/buffered_logging.go b/sdks/go/container/tools/buffered_logging.go index a7b84e56af3a..a0937b8eb14a 100644 --- a/sdks/go/container/tools/buffered_logging.go +++ b/sdks/go/container/tools/buffered_logging.go @@ -78,7 +78,7 @@ func (b *BufferedLogger) FlushAtError(ctx context.Context) { return } for _, message := range b.logs { - b.logger.Errorf(ctx, message) + b.logger.Errorf(ctx, "%s", message) } b.logs = nil b.lastFlush = time.Now() @@ -91,7 +91,7 @@ func (b *BufferedLogger) FlushAtDebug(ctx context.Context) { return } for _, message := range b.logs { - b.logger.Printf(ctx, message) + b.logger.Printf(ctx, "%s", message) } b.logs = nil b.lastFlush = time.Now() diff --git a/sdks/go/container/tools/logging_test.go b/sdks/go/container/tools/logging_test.go index 8730a0fe9c19..c68600f75e2e 100644 --- a/sdks/go/container/tools/logging_test.go +++ b/sdks/go/container/tools/logging_test.go @@ -85,7 +85,7 @@ func TestLogger(t *testing.T) { catcher.err = errors.New("test error") wantMsg := "checking for error?" - l.Printf(ctx, wantMsg) + l.Printf(ctx, "%s", wantMsg) line, err := buf.ReadString('\n') if err != nil { diff --git a/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go b/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go index ed706ec1a482..96c0750d18e3 100644 --- a/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go +++ b/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go @@ -262,7 +262,7 @@ func WaitForCompletion(ctx context.Context, client *df.Service, project, region, if err != nil { return err } - log.Infof(ctx, msg) + log.Infof(ctx, "%s", msg) if terminal { return nil } diff --git a/sdks/python/container/boot.go b/sdks/python/container/boot.go index b7cbc07dca68..847325d4f83c 100644 --- a/sdks/python/container/boot.go +++ b/sdks/python/container/boot.go @@ -188,7 +188,7 @@ func launchSDKProcess() error { if err != nil { fmtErr := fmt.Errorf("failed to retrieve staged files: %v", err) // Send error message to logging service before returning up the call stack - logger.Errorf(ctx, fmtErr.Error()) + logger.Errorf(ctx, "%s", fmtErr.Error()) // No need to fail the job if submission_environment_dependencies.txt cannot be loaded if strings.Contains(fmtErr.Error(), "submission_environment_dependencies.txt") { logger.Printf(ctx, "Ignore the error when loading submission_environment_dependencies.txt.") @@ -214,7 +214,7 @@ func launchSDKProcess() error { if setupErr := installSetupPackages(ctx, logger, fileNames, dir, requirementsFiles); setupErr != nil { fmtErr := fmt.Errorf("failed to install required packages: %v", setupErr) // Send error message to logging service before returning up the call stack - logger.Errorf(ctx, fmtErr.Error()) + logger.Errorf(ctx, "%s", fmtErr.Error()) return fmtErr } @@ -500,6 +500,6 @@ func logSubmissionEnvDependencies(ctx context.Context, bufLogger *tools.Buffered if err != nil { return err } - bufLogger.Printf(ctx, string(content)) + bufLogger.Printf(ctx, "%s", string(content)) return nil }