Skip to content

Add missing format strings to logging calls in the Go SDK #36192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrmccluskey merged 1 commit into from
Sep 18, 2025
+7 −7
Merged

Add missing format strings to logging calls in the Go SDK #36192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/go/container/tools/buffered_logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (b *BufferedLogger) FlushAtError(ctx context.Context) {
return
}
for _, message := range b.logs {
b.logger.Errorf(ctx, message)
b.logger.Errorf(ctx, "%s", message)
}
b.logs = nil
b.lastFlush = time.Now()
Expand All @@ -91,7 +91,7 @@ func (b *BufferedLogger) FlushAtDebug(ctx context.Context) {
return
}
for _, message := range b.logs {
b.logger.Printf(ctx, message)
b.logger.Printf(ctx, "%s", message)
}
b.logs = nil
b.lastFlush = time.Now()
Expand Down
2 changes: 1 addition & 1 deletion sdks/go/container/tools/logging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func TestLogger(t *testing.T) {

catcher.err = errors.New("test error")
wantMsg := "checking for error?"
l.Printf(ctx, wantMsg)
l.Printf(ctx, "%s", wantMsg)

line, err := buf.ReadString('\n')
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ func WaitForCompletion(ctx context.Context, client *df.Service, project, region,
if err != nil {
return err
}
log.Infof(ctx, msg)
log.Infof(ctx, "%s", msg)
if terminal {
return nil
}
Expand Down
6 changes: 3 additions & 3 deletions sdks/python/container/boot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func launchSDKProcess() error {
if err != nil {
fmtErr := fmt.Errorf("failed to retrieve staged files: %v", err)
// Send error message to logging service before returning up the call stack
logger.Errorf(ctx, fmtErr.Error())
logger.Errorf(ctx, "%s", fmtErr.Error())
// No need to fail the job if submission_environment_dependencies.txt cannot be loaded
if strings.Contains(fmtErr.Error(), "submission_environment_dependencies.txt") {
logger.Printf(ctx, "Ignore the error when loading submission_environment_dependencies.txt.")
Expand All @@ -214,7 +214,7 @@ func launchSDKProcess() error {
if setupErr := installSetupPackages(ctx, logger, fileNames, dir, requirementsFiles); setupErr != nil {
fmtErr := fmt.Errorf("failed to install required packages: %v", setupErr)
// Send error message to logging service before returning up the call stack
logger.Errorf(ctx, fmtErr.Error())
logger.Errorf(ctx, "%s", fmtErr.Error())
return fmtErr
}

Expand Down Expand Up @@ -500,6 +500,6 @@ func logSubmissionEnvDependencies(ctx context.Context, bufLogger *tools.Buffered
if err != nil {
return err
}
bufLogger.Printf(ctx, string(content))
bufLogger.Printf(ctx, "%s", string(content))
return nil
}
Loading