Skip to content

Revert "Update Beam Protobuf Schema (Java) (#35150)" - #36288

Closed
Abacn wants to merge 1 commit into
masterfrom
revert-35150-fix-35081
Closed

Revert "Update Beam Protobuf Schema (Java) (#35150)"#36288
Abacn wants to merge 1 commit into
masterfrom
revert-35150-fix-35081

Conversation

@Abacn

@Abacn Abacn commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

This reverts commit c3ef7f3.

Fix https://github.com/apache/beam/actions/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml.

When rolling forward, consider trigger this task (by changing .github/trigger_files)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a recent update to the Beam Protobuf Schema in Java, aiming to resolve issues that were causing a specific GitHub Actions workflow to fail. The changes involve a significant internal refactoring of how Protobuf messages are translated to and from Beam Rows. This includes replacing the older ProtoBeamConverter with a new ProtoDynamicMessageSchema that employs a more granular, type-specific conversion strategy. Additionally, the handling of nullability for schema fields has been streamlined, leading to the removal of the FieldValueHaver interface and related ByteBuddy code. The Schema class's toString() method has also been updated to provide a more comprehensive output.

Highlights

  • Revert of Protobuf Schema Update: This pull request primarily reverts a previous commit that updated the Beam Protobuf Schema in Java, specifically addressing a failing GitHub Actions workflow.
  • Refactoring of Protobuf-to-Beam Conversion: The previous ProtoBeamConverter class has been entirely removed and its functionality replaced by a new, modular ProtoDynamicMessageSchema. This new implementation introduces a more structured approach with dedicated Convert classes for various Protobuf field types.
  • Simplification of Nullability Handling: The explicit FieldValueHaver interface and its associated ByteBuddy generation logic for checking field presence have been removed. Nullability for Protobuf fields is now handled more directly within the schema translation and conversion logic, including updates to logical types to correctly handle null inputs.
  • Enhanced Schema toString() Method: The Schema.java class now provides a more detailed and human-readable toString() representation, with this formatting logic moved directly into the Schema class and removed from SchemaUtils.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn Abacn mentioned this pull request Sep 26, 2025
3 tasks
@Abacn Abacn closed this Sep 26, 2025
@Abacn
Abacn deleted the revert-35150-fix-35081 branch October 3, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant