Skip to content

Fix typevar reduce for PYPI.#36299

Merged
tvalentyn merged 1 commit intoapache:masterfrom
claudevdm:fix-cloudpickle-typevar
Sep 26, 2025
Merged

Fix typevar reduce for PYPI.#36299
tvalentyn merged 1 commit intoapache:masterfrom
claudevdm:fix-cloudpickle-typevar

Conversation

@claudevdm
Copy link
Copy Markdown
Collaborator

@claudevdm claudevdm commented Sep 26, 2025

Follow up fix for #35422

I did not run tests suites on my original changes in a PYPI env, and there was a bug in the typevar reduce for this case.

This fixes the bug and all tests pass in PYPI env now.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm
Copy link
Copy Markdown
Collaborator Author

R: @tvalentyn

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug within the cloudpickle library's typevar reduce functionality, which manifested specifically when running in a PYPI environment. The fix involves a minor but crucial adjustment to the serialization logic for TypeVar objects, ensuring proper handling and allowing all associated tests to pass as expected in the affected environment.

Highlights

  • Bug Fix: Resolved a bug in the typevar reduce mechanism that specifically occurred in a PYPI environment, preventing tests from passing.
  • Serialization Logic: Modified the save_typevar method in cloudpickle.py to use self.save_reduce instead of self._save_reduce_pickle5 for handling TypeVar objects.
  • Test Validation: Confirmed that all tests now pass successfully in the PYPI environment after applying this fix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@tvalentyn
Copy link
Copy Markdown
Contributor

Is this a follow up to some other change?

@claudevdm
Copy link
Copy Markdown
Collaborator Author

Is this a follow up to some other change?

This is a follow up to #35422

@tvalentyn
Copy link
Copy Markdown
Contributor

LGTM

@tvalentyn tvalentyn merged commit 53bba28 into apache:master Sep 26, 2025
95 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants