Upgrade sqlline from 1.4.0 to 1.12.0

[talatuyarer]

Just upgraded our sqlline dependency from the ancient 1.4.0 to the shiny new 1.12.0. This brings a ton of cool new features and makes the SQL CLI experience way better.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @talatuyarer, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant upgrade of the sqlline dependency from an older version (1.4.0) to a much newer one (1.12.0). This update aims to modernize the SQL command-line interface within the project, providing users with a more feature-rich and improved experience. The changes involve not only the dependency bump but also necessary adaptations to the application's code and testing utilities to ensure compatibility and leverage the new sqlline version's capabilities, particularly in handling output formatting and connection defaults.

Highlights

• Dependency Upgrade: The sqlline dependency has been upgraded from version 1.4.0 to 1.12.0, bringing numerous new features and improvements to the SQL CLI experience.
• Default Credentials for BeamSqlLine: Default username and password (beam/beam) are now automatically added to BeamSqlLine arguments if not specified, preventing interactive prompts during connection and streamlining the user experience.
• Updated SQLLine Properties and Help: The SqlLine.properties file has been extensively updated to reflect the new commands, variables, and help messages introduced in sqlline 1.12.0, including new command-line options and variable definitions.
• Test Adaptations for New Output Format: Existing tests in BeamSqlLineTest.java were adjusted to accommodate potential changes in output formatting from the upgraded sqlline library, ensuring continued correctness.
• Enhanced Output Parsing Logic: The BeamSqlLineTestingUtils.java file now includes enhanced logic to correctly parse the new table output format used by sqlline 1.12.0, specifically handling table borders and improved field extraction.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[talatuyarer]

/gemini review

[gemini-code-assist]

Code Review

This pull request upgrades the sqlline dependency and adapts the codebase to the new version. The changes are generally well-executed, including updates to the build file, command-line argument handling, and test assertions. I've identified a couple of areas for improvement. There's an opportunity to improve maintainability by replacing hardcoded credentials with constants. More importantly, I've found significant issues in the new test output parsing logic which could lead to incorrect test results, and I've provided a more robust implementation to address this.

[github-actions]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

[github-actions]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.