Skip to content

Upgrade sqlline from 1.4.0 to 1.12.0 #36322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talatuyarer wants to merge 2 commits into from
Closed

Upgrade sqlline from 1.4.0 to 1.12.0 #36322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f38550a
Upgrade sqlline 1.12
talatuyarer Sep 30, 2025
437a22e
Addressed Gemini's comments
talatuyarer Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/java/extensions/sql/jdbc/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ dependencies {
implementation project(":sdks:java:extensions:sql")
implementation "jline:jline:2.14.6"
permitUnusedDeclared "jline:jline:2.14.6" // BEAM-11761
implementation "sqlline:sqlline:1.4.0"
implementation "sqlline:sqlline:1.12.0"
implementation library.java.vendored_calcite_1_40_0
permitUnusedDeclared library.java.vendored_calcite_1_40_0
testImplementation project(path: ":sdks:java:core", configuration: "shadow")
Expand Down
13 changes: 13 additions & 0 deletions ...xtensions/sql/jdbc/src/main/java/org/apache/beam/sdk/extensions/sql/jdbc/BeamSqlLine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
public class BeamSqlLine {

private static final String NICKNAME = "BeamSQL";
private static final String DEFAULT_USER = "beam";
private static final String DEFAULT_PASSWORD = "beam";

public static void main(String[] args) throws IOException {
runSqlLine(args, null, System.out, System.err);
Expand All @@ -53,6 +55,17 @@ private static String[] checkConnectionArgs(String[] args) {
argsList.add(CONNECT_STRING_PREFIX);
}

// Add default credentials to prevent interactive prompts
if (!argsList.contains("-n")) {
argsList.add("-n");
argsList.add(DEFAULT_USER);
}

if (!argsList.contains("-p")) {
argsList.add("-p");
argsList.add(DEFAULT_PASSWORD);
}
Comment thread
talatuyarer marked this conversation as resolved.

return argsList.toArray(new String[argsList.size()]);
}

Expand Down
Loading
Loading