From 13dde3aa2fdbd33cf9626a2bdc46e418ccea6c91 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 9 Sep 2025 11:09:42 -0400 Subject: [PATCH 1/3] Add dill test workflow. --- .../workflows/beam_PreCommit_Python_Dill.yml | 125 ++++++++++++++++++ 1 file changed, 125 insertions(+) create mode 100644 .github/workflows/beam_PreCommit_Python_Dill.yml diff --git a/.github/workflows/beam_PreCommit_Python_Dill.yml b/.github/workflows/beam_PreCommit_Python_Dill.yml new file mode 100644 index 000000000000..afc055634973 --- /dev/null +++ b/.github/workflows/beam_PreCommit_Python_Dill.yml @@ -0,0 +1,125 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: PreCommit Python Dill tests with dill deps installed +on: + pull_request_target: + branches: [ "master", "release-*" ] + paths: [ "model/**","sdks/python/**","release/**", 'release/trigger_all_tests.json', '.github/trigger_files/beam_PreCommit_Python_Dill.json'] + issue_comment: + types: [created] + push: + tags: ['v*'] + branches: ['master', 'release-*'] + paths: [ "model/**","sdks/python/**","release/**",".github/workflows/beam_PreCommit_Python_Dill.yml"] + schedule: + - cron: '45 2/6 * * *' + workflow_dispatch: + +#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event +permissions: + actions: write + pull-requests: write + checks: write + contents: read + deployments: read + id-token: none + issues: write + discussions: read + packages: read + pages: read + repository-projects: read + security-events: read + statuses: read + +# This allows a subsequently queued workflow run to interrupt previous runs +concurrency: + group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login }}' + cancel-in-progress: true + +env: + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} + GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }} + GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }} + +jobs: + beam_PreCommit_Python_Dill: + name: ${{ matrix.job_name }} (${{ matrix.job_phrase }} ${{ matrix.python_version }}) + runs-on: ${{ matrix.os }} + timeout-minutes: 180 + strategy: + fail-fast: false + matrix: + job_name: ['beam_PreCommit_Python_Dill'] + job_phrase: ['Run Python_Dill PreCommit'] + python_version: ['3.12'] + # Run on both self-hosted and GitHub-hosted runners. + # Some tests (marked require_docker_in_docker) can't run on Beam's + # self-hosted runners due to Docker-in-Docker environment constraint. + # These tests will only execute on ubuntu-latest (GitHub-hosted). + # Context: https://github.com/apache/beam/pull/35585 + # Temporary removed the ubuntu-latest env till resolving deps issues. + os: [[self-hosted, ubuntu-20.04, main]] + if: | + github.event_name == 'push' || + github.event_name == 'pull_request_target' || + (github.event_name == 'schedule' && github.repository == 'apache/beam') || + github.event_name == 'workflow_dispatch' || + startsWith(github.event.comment.body, 'Run Python_Dill PreCommit') + steps: + - uses: actions/checkout@v4 + - name: Setup repository + uses: ./.github/actions/setup-action + with: + comment_phrase: ${{ matrix.job_phrase }} ${{ matrix.python_version }} + github_token: ${{ secrets.GITHUB_TOKEN }} + github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }} ${{ matrix.python_version }}) + - name: Setup environment + uses: ./.github/actions/setup-environment-action + with: + java-version: default + python-version: ${{ matrix.python_version }} + - name: Set PY_VER_CLEAN + id: set_py_ver_clean + run: | + PY_VER=${{ matrix.python_version }} + PY_VER_CLEAN=${PY_VER//.} + echo "py_ver_clean=$PY_VER_CLEAN" >> $GITHUB_OUTPUT + - name: Run pythonPreCommit + uses: ./.github/actions/gradle-command-self-hosted-action + with: + gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:testPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}Dill + arguments: | + -Pposargs="${{ + contains(matrix.os, 'self-hosted') && + 'apache_beam/internal/ apache_beam/ml/ apache_beam/transforms/ apache_beam/typehints/ apache_beam/runners/portability/ -m (uses_dill and not require_docker_in_docker)' || + 'apache_beam/internal/ apache_beam/ml/ apache_beam/transforms/ apache_beam/typehints/ apache_beam/runners/portability/ -m (uses_dill and require_docker_in_docker)' + }}" \ + -PpythonVersion=${{ matrix.python_version }} + - name: Archive Python Test Results + uses: actions/upload-artifact@v4 + if: failure() + with: + name: Python ${{ matrix.python_version }} Test Results + path: '**/pytest*.xml' + - name: Publish Python Test Results + uses: EnricoMi/publish-unit-test-result-action@v2 + if: always() + with: + commit: '${{ env.prsha || env.GITHUB_SHA }}' + comment_mode: ${{ github.event_name == 'issue_comment' && 'always' || 'off' }} + files: '**/pytest*.xml' + large_files: true + From 87f9deab6330fe48cb2298ac1cfd05019c25637d Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 1 Oct 2025 17:26:51 +0000 Subject: [PATCH 2/3] Disable other triggers temporarily. --- .github/workflows/beam_PreCommit_Python_Dill.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/beam_PreCommit_Python_Dill.yml b/.github/workflows/beam_PreCommit_Python_Dill.yml index afc055634973..ae56a3c99873 100644 --- a/.github/workflows/beam_PreCommit_Python_Dill.yml +++ b/.github/workflows/beam_PreCommit_Python_Dill.yml @@ -17,13 +17,15 @@ name: PreCommit Python Dill tests with dill deps installed on: pull_request_target: branches: [ "master", "release-*" ] - paths: [ "model/**","sdks/python/**","release/**", 'release/trigger_all_tests.json', '.github/trigger_files/beam_PreCommit_Python_Dill.json'] + # paths: [ "model/**","sdks/python/**","release/**", 'release/trigger_all_tests.json', '.github/trigger_files/beam_PreCommit_Python_Dill.json'] + paths: [ '.github/trigger_files/beam_PreCommit_Python_Dill.json'] issue_comment: types: [created] push: tags: ['v*'] branches: ['master', 'release-*'] - paths: [ "model/**","sdks/python/**","release/**",".github/workflows/beam_PreCommit_Python_Dill.yml"] + # paths: [ "model/**","sdks/python/**","release/**",".github/workflows/beam_PreCommit_Python_Dill.yml"] + paths: [ ".github/workflows/beam_PreCommit_Python_Dill.yml"] schedule: - cron: '45 2/6 * * *' workflow_dispatch: From cc555d38291400d56e87987b03c25eb10d8e97fc Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 1 Oct 2025 18:28:00 +0000 Subject: [PATCH 3/3] Trigger on release to make checks pass. --- .github/workflows/beam_PreCommit_Python_Dill.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/beam_PreCommit_Python_Dill.yml b/.github/workflows/beam_PreCommit_Python_Dill.yml index ae56a3c99873..aa847da3b491 100644 --- a/.github/workflows/beam_PreCommit_Python_Dill.yml +++ b/.github/workflows/beam_PreCommit_Python_Dill.yml @@ -18,14 +18,16 @@ on: pull_request_target: branches: [ "master", "release-*" ] # paths: [ "model/**","sdks/python/**","release/**", 'release/trigger_all_tests.json', '.github/trigger_files/beam_PreCommit_Python_Dill.json'] - paths: [ '.github/trigger_files/beam_PreCommit_Python_Dill.json'] + paths: [ '.github/trigger_files/beam_PreCommit_Python_Dill.json', 'release/trigger_all_tests.json'] issue_comment: types: [created] push: tags: ['v*'] branches: ['master', 'release-*'] # paths: [ "model/**","sdks/python/**","release/**",".github/workflows/beam_PreCommit_Python_Dill.yml"] - paths: [ ".github/workflows/beam_PreCommit_Python_Dill.yml"] + paths: [ ".github/workflows/beam_PreCommit_Python_Dill.yml", 'release/trigger_all_tests.json'] + workflow_run: + types: [created] schedule: - cron: '45 2/6 * * *' workflow_dispatch: