Skip to content

Remove unneeded base64 encoding of pickled data. #36359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robertwb wants to merge 1 commit into from
Closed

Remove unneeded base64 encoding of pickled data. #36359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions sdks/python/apache_beam/internal/cloudpickle_pickler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

# pytype: skip-file

import base64
import bz2
import io
import logging
Expand Down Expand Up @@ -154,25 +153,18 @@ def dumps(
# representation change, and can break streaming job update compatibility on
# runners such as Dataflow.
if use_zlib:
c = zlib.compress(s, 9)
return zlib.compress(s, 9)
else:
c = bz2.compress(s, compresslevel=9)
del s # Free up some possibly large and no-longer-needed memory.

return base64.b64encode(c)
return bz2.compress(s, compresslevel=9)


def loads(encoded, enable_trace=True, use_zlib=False):
"""For internal use only; no backwards-compatibility guarantees."""

c = base64.b64decode(encoded)

if use_zlib:
s = zlib.decompress(c)
s = zlib.decompress(encoded)
else:
s = bz2.decompress(c)

del c # Free up some possibly large and no-longer-needed memory.
s = bz2.decompress(encoded)

with _pickle_lock:
unpickled = cloudpickle.loads(s)
Expand Down
Loading