GCP User IAM workflow modified to post Terraform plan as a comment on PRs - #36375
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
R: @pabloem |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
this looks good to me.- have you tested it? we could test it in this PR direcly by changing users.yml |
Haven't tested it yet, maybe we could migrate my user to the viewer role? |
sure that works! - you can make the change in this PR and we should see the comment appear |
cebd433 to
64fa9fd
Compare
64fa9fd to
5b92d0a
Compare
Changing event_name to p_r_t, and removing the specific ref to checkout
removing all p_r_t filters to make it match all prs
|
lgtm! |
2 participants
This PR updates
.github/workflows/beam_Infrastructure_UsersPermissions.ymlto improve the review of IAM changes. The main change is adding a comment on each PR, commenting the changes plan generated by Terraform. Apply command has now been restricted only on pushes to master branch.