Skip to content

Use nested context in java TestStream #36412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shunping wants to merge 1 commit into from
Closed

Use nested context in java TestStream #36412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions runners/prism/java/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,13 @@ def sickbayTests = [

// Prism doesn't support multiple TestStreams.
'org.apache.beam.sdk.testing.TestStreamTest.testMultipleStreams',
// Sometimes fails missing a final 'AFTER'. Otherwise, Hangs in ElementManager.FailBundle due to a held stageState lock.
'org.apache.beam.sdk.testing.TestStreamTest.testMultiStage',

// GroupIntoBatchesTest tests that fail:
// Teststream has bad KV encodings due to using an outer context.
// Wrong number of elements in windows after GroupIntoBatches: null
// Incorrect output collection after GroupIntoBatches: null
'org.apache.beam.sdk.transforms.GroupIntoBatchesTest.testInStreamingMode',
'org.apache.beam.sdk.transforms.GroupIntoBatchesTest.testBufferingTimerInFixedWindow',
// sdk worker disconnected
// varint overflow 4120879041988 on counting step
'org.apache.beam.sdk.transforms.GroupIntoBatchesTest.testBufferingTimerInGlobalWindow',
// ShardedKey not yet implemented.
'org.apache.beam.sdk.transforms.GroupIntoBatchesTest.testWithShardedKeyInGlobalWindow',
Expand Down
4 changes: 2 additions & 2 deletions sdks/go/pkg/beam/runners/prism/internal/execute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,8 @@ func executePipeline(ctx context.Context, wks map[string]*worker.W, j *jobservic
//slog.Warn("teststream bytes", "value", string(v), "bytes", v)
return v
}
// Hack for Java Strings in test stream, since it doesn't encode them correctly.
forceLP := cID == "StringUtf8Coder" || cID != pyld.GetCoderId()
// the coder from teststream payload has to be LP'ed
forceLP := cID != pyld.GetCoderId()

@shunping shunping Oct 6, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The java hack is only relevant to "StringUtf8Coder". If the coder has been LP'ed, we have to the data too.

if forceLP {
// slog.Warn("recoding TestStreamValue", "cID", cID, "newUrn", coders[cID].GetSpec().GetUrn(), "payloadCoder", pyld.GetCoderId(), "oldUrn", coders[pyld.GetCoderId()].GetSpec().GetUrn())
// The coder needed length prefixing. For simplicity, add a length prefix to each
Expand Down
2 changes: 2 additions & 0 deletions sdks/go/pkg/beam/runners/prism/internal/preprocess.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"github.com/apache/beam/sdks/v2/go/pkg/beam/runners/prism/internal/jobservices"
"github.com/apache/beam/sdks/v2/go/pkg/beam/runners/prism/internal/urns"
"golang.org/x/exp/maps"
"google.golang.org/protobuf/encoding/prototext"
"google.golang.org/protobuf/proto"
)

Expand Down Expand Up @@ -152,6 +153,7 @@ func (p *preprocessor) preProcessGraph(comps *pipepb.Components, j *jobservices.
}

// Extract URNs for the given transform.
slog.Debug("components in pipeline proto", "proto", prototext.Format(comps))

keptLeaves := maps.Keys(leaves)
sort.Strings(keptLeaves)
Expand Down
6 changes: 4 additions & 2 deletions .../java/core/src/main/java/org/apache/beam/sdk/util/construction/TestStreamTranslation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ static <T> RunnerApi.TestStreamPayload.Event eventToProto(
.setTimestamp(element.getTimestamp().getMillis())
.setEncodedElement(
ByteString.copyFrom(
CoderUtils.encodeToByteArray(coder, element.getValue()))));
CoderUtils.encodeToByteArray(
coder, element.getValue(), Coder.Context.NESTED))));
}
return RunnerApi.TestStreamPayload.Event.newBuilder().setElementEvent(builder).build();
default:
Expand All @@ -149,7 +150,8 @@ static <T> TestStream.Event<T> eventFromProto(
protoEvent.getElementEvent().getElementsList()) {
decodedElements.add(
TimestampedValue.of(
CoderUtils.decodeFromByteArray(coder, element.getEncodedElement().toByteArray()),
CoderUtils.decodeFromByteArray(
coder, element.getEncodedElement().toByteArray(), Coder.Context.NESTED),
new Instant(element.getTimestamp())));
}
return TestStream.ElementEvent.add(decodedElements);
Expand Down
Loading