Skip to content

[Dataflow Streaming] Fix outstanding bundle metric reporting - #36455

Merged
scwhittle merged 1 commit into
apache:masterfrom
arunpandianp:fix_outstanding_bundle_metric
Oct 10, 2025
Merged

[Dataflow Streaming] Fix outstanding bundle metric reporting#36455
scwhittle merged 1 commit into
apache:masterfrom
arunpandianp:fix_outstanding_bundle_metric

Conversation

@arunpandianp

@arunpandianp arunpandianp commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

The value was getting set in setActiveBundleCount instead of in setOutstandingBundleCount.

@arunpandianp

arunpandianp commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

R: @scwhittle

@gemini-code-assist

gemini-code-assist Bot commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @arunpandianp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in the Dataflow Streaming worker's status reporting mechanism. It ensures that the elementsOutstanding() metric, which indicates the number of bundles awaiting processing, is accurately reported by calling the correct setter method. This correction is essential for maintaining reliable monitoring and proper scaling behavior within the Dataflow environment.

Highlights

  • Metric Correction: Fixed an issue where the elementsOutstanding() metric was being reported incorrectly in the Dataflow Streaming worker.
  • Corrected Setter Method: The value was previously assigned to setActiveBundleCount and is now correctly assigned to setOutstandingBundleCount.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions

github-actions Bot commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@scwhittle
scwhittle merged commit c5a6189 into apache:master Oct 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dataflow runners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arunpandianp @scwhittle