Move the logic to LP TestStream encoded bytes to transform preparer - #36465
Merged
Conversation
shunping
changed the title
shunping
marked this pull request as ready for review
October 10, 2025 03:48
Collaborator
Author
|
R: @lostluck as it is a follow-up PR. |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Collaborator
Author
Great! Glad that you agree with this. I think it is clearer this way than making the adjustments while doing building descriptors (including passing extra PCollections/coder replacements around) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up PR to #36424.
Add a new transform preparer for TestStream and move the logic of LP'ing its encoded bytes there. In this case, we can modify the comps earlier during the preprocessing step and ensure they are in good shape during stage building later.
fixes #36440