Skip to content

Support newer versions of pyarrow. - #36845

Closed
aebrahim wants to merge 2 commits into
apache:masterfrom
aebrahim:upgrade_pyarrow
Closed

Support newer versions of pyarrow.#36845
aebrahim wants to merge 2 commits into
apache:masterfrom
aebrahim:upgrade_pyarrow

Conversation

@aebrahim

Copy link
Copy Markdown

Increase supported pyarrow version up to the latest one.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @aebrahim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the supported range for the pyarrow library, enabling compatibility with its latest versions up to 23.0.0. The changes involve adjusting the dependency specification in the project's setup.py and expanding the test suite to validate functionality against these newly supported pyarrow releases.

Highlights

  • Pyarrow Dependency Update: The upper bound for the pyarrow dependency in setup.py has been increased from <19.0.0 to <23.0.0, allowing the project to support newer versions of pyarrow.
  • Expanded Test Matrix: The tox.ini configuration has been updated to include pyarrow versions 19 through 22 in the test environments, ensuring compatibility and stability with these newer releases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @jrmccluskey for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @jrmccluskey

@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

Comment thread sdks/python/tox.ini Outdated
Comment thread sdks/python/tox.ini
@aebrahim
aebrahim requested a review from damccorm December 5, 2025 23:28
@aebrahim

aebrahim commented Dec 5, 2025

Copy link
Copy Markdown
Author

Thanks for the review! Done :)

@github-actions

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @damccorm

@damccorm

Copy link
Copy Markdown
Contributor

It looks like there might be a persistent precommit failure at the current commit. Could you please try pulling in the latest changes from master so that hopefully we can get a better signal here?

@github-actions

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @damccorm

@damccorm

Copy link
Copy Markdown
Contributor

waiting on author

@aebrahim

Copy link
Copy Markdown
Author

Just rebased on latest master

@damccorm

Copy link
Copy Markdown
Contributor

Ok, it looks like this is causing some parquet tests to fail persistently (test_dynamic_work_rebalancing). Would you mind taking a look? The test in question is

def test_dynamic_work_rebalancing(self):

@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @damccorm

@damccorm

damccorm commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

waiting on author

@github-actions

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @damccorm

@damccorm

Copy link
Copy Markdown
Contributor

waiting on author

@sadovnychyi

sadovnychyi commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Any chances to include 23 as well?

tensorflow/tensorflow#98563 (comment)

UPDATE: Oh, nevermind, the comment I link to actually says 22. It just that pyarrow + tensorflow cause all kinds of issues on mac which is crazy.

@damccorm

damccorm commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

FYI #37503 pushed this over the finish line

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Apr 6, 2026
@damccorm

damccorm commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Closing since #37503 ended up doing this

@damccorm damccorm closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants