Skip to content

Fix Python PostCommit Dependency: centralize Vertex AI test skip #37774

Closed
aIbrahiim wants to merge 2 commits intoapache:masterfrom
aIbrahiim:fix-python-postcommit-dependency-3
Closed

Fix Python PostCommit Dependency: centralize Vertex AI test skip #37774
aIbrahiim wants to merge 2 commits intoapache:masterfrom
aIbrahiim:fix-python-postcommit-dependency-3

Conversation

@aIbrahiim
Copy link
Copy Markdown
Contributor

@aIbrahiim aIbrahiim commented Mar 4, 2026


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions Bot added the python label Mar 4, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors how Vertex AI integration tests are skipped when their dependencies are not met. By centralizing the skip logic into a dedicated module and applying it at the class level, the change improves the maintainability and consistency of the test suite, ensuring that tests requiring Vertex AI are only run when the environment is properly configured.

Highlights

  • Centralized Vertex AI Test Skipping: Introduced a new utility module vertex_ai_skip.py to centralize the logic for conditionally skipping Vertex AI integration tests when the necessary dependencies are not available.
  • Refactored Test Decorators: Applied the new @skip_if_vertex_ai_disabled decorator to relevant Vertex AI test classes, ensuring tests are skipped consistently if the Vertex AI SDK is missing. This also involved moving the @pytest.mark.vertex_ai_postcommit decorator from individual test methods to the class level for better organization.
  • Improved Test Dependency Management: Streamlined the handling of optional Vertex AI dependencies in tests, making the test suite more robust and easier to manage across different environments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/apache_beam/ml/inference/vertex_ai_inference_it_test.py
    • Imported skip_if_vertex_ai_disabled from the new utility module.
    • Applied @skip_if_vertex_ai_disabled and @pytest.mark.vertex_ai_postcommit to the VertexAIInference test class.
    • Removed redundant @pytest.mark.vertex_ai_postcommit decorators from individual test methods within the class.
  • sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai_test.py
    • Imported pytest and skip_if_vertex_ai_disabled.
    • Applied @skip_if_vertex_ai_disabled and @pytest.mark.vertex_ai_postcommit to VertexAIEmbeddingsTest and VertexAIMultiModalEmbeddings test classes.
  • sdks/python/apache_beam/testing/vertex_ai_skip.py
    • Added a new file to define _is_vertex_ai_available function to check for Vertex AI client dependencies.
    • Introduced skip_if_vertex_ai_disabled as a pytest.mark.skipif decorator based on the availability of Vertex AI dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@aIbrahiim aIbrahiim closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant