[ErrorProne] enable ClassInitializationDeadlock, Finalize, NullableTypeParameter, ThreadPriorityCheck

[stankiewicz]

Enable error-prone checks: ClassInitializationDeadlock, Finalize, NullableTypeParameter, ThreadPriorityCheck
and suppress all occurences as they are needed.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the project's code quality and robustness by activating several new ErrorProne static analysis checks. These checks are designed to identify common programming pitfalls related to class initialization, object finalization, nullable type parameters, and thread priority management. The change involves a two-step process: first, enabling these checks globally, and then carefully applying suppressions to existing code where the identified patterns are deemed acceptable or necessary, thus preventing new occurrences of these issues without requiring extensive refactoring.

Highlights

• ErrorProne Checks Enabled: Four new ErrorProne checks have been enabled: ClassInitializationDeadlock, Finalize, NullableTypeParameter, and ThreadPriorityCheck. These checks enhance static analysis to catch potential issues earlier in the development cycle.
• Targeted Warning Suppressions: Existing code that triggered warnings from the newly enabled checks has been updated with targeted @SuppressWarnings annotations. This ensures that the new checks are active for future code while allowing current, stable implementations to remain unchanged.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
  • Enabled ClassInitializationDeadlock, Finalize, NullableTypeParameter, and ThreadPriorityCheck ErrorProne checks by removing them from the default suppression list.
• runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/ApplianceShuffleReader.java
  • Suppressed the Finalize ErrorProne check for the finalize method.
• runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/ApplianceShuffleWriter.java
  • Suppressed the Finalize ErrorProne check for the finalize method.
• runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchDataflowWorker.java
  • Suppressed the ThreadPriorityCheck ErrorProne check for the startMemoryMonitorThread method.
• runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/WindmillServerBase.java
  • Suppressed the Finalize ErrorProne check for the finalize method.
• sdks/java/core/src/main/java/org/apache/beam/sdk/io/UnboundedSource.java
  • Suppressed the ClassInitializationDeadlock ErrorProne check for the NOOP_CHECKPOINT_MARK field.
• sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignature.java
  • Suppressed the ClassInitializationDeadlock ErrorProne check for the Parameter abstract class.
• sdks/java/core/src/main/java/org/apache/beam/sdk/util/UnboundedScheduledExecutorService.java
  • Suppressed the NullableTypeParameter ErrorProne check for the UnboundedScheduledExecutorService class.
• sdks/java/harness/src/main/java/org/apache/beam/fn/harness/status/BeamFnStatusClient.java
  • Suppressed the ThreadPriorityCheck ErrorProne check for the constructor.
• sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/catalog/hiveutils/ScriptRunner.java
  • Suppressed the ThreadPriorityCheck ErrorProne check for the ScriptRunner class.
• sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
  • Suppressed the NullableTypeParameter ErrorProne check for the NullOnlyCoder class.
• sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Cache.java
  • Suppressed the NullableTypeParameter ErrorProne check for the Cache class.

Activity

• No specific activity (comments, reviews, progress) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[github-actions]

Assigning reviewers:

R: @kennknowles for label java.
R: @damccorm for label build.
R: @johnjcasey for label kafka.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[stankiewicz]

Thanks @kennknowles , will address comments shortly.

[github-actions]

Reminder, please take a look at this pr: @kennknowles @damccorm @johnjcasey

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java.
R: @liferoad for label build.
R: @Abacn for label kafka.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[damccorm]

waiting on author

[stankiewicz]

updated & rebased

[stankiewicz]

this is only suppression but enabling it will help resolving future issues.

[damccorm]

Thanks!

[Abacn]

this is only suppression but enabling it will help resolving future issues.

Can we add this comment back

// intended suppressions emerged in newer errorprone versions

or

intended suppressions with justifications

The suppression below this line were preferred for performance/backward compatibility or other reasons that may affect actual functionality and not merely code style issue

In case future "fix" on these suppressions may introduce unwanted change

[stankiewicz]

thanks for looking into this , will do.