Skip to content

Run python_dependency_tests during release validation.#38070

Merged
tvalentyn merged 2 commits intomasterfrom
tvalentyn-patch-11
Apr 3, 2026
Merged

Run python_dependency_tests during release validation.#38070
tvalentyn merged 2 commits intomasterfrom
tvalentyn-patch-11

Conversation

@tvalentyn
Copy link
Copy Markdown
Contributor

Python beam 2.72.0 containers fail pip check.

docker run --rm -it --entrypoint=/bin/bash apache/beam_python3.11_sdk:2.72.0
root@dba2986b7302:/# pip check
apache-beam 2.72.0 requires pillow, which is not installed.

The rootcause:

I have the following asks that should help reduce preventable issues in the release :

  • We should take a look whether any other tests suites need to be amended to also run during release branch validation.
  • We need to change the release procedure to rerun tests on the release validation PR after making cherry-pick changes. If we only run the tests once, we might miss errors like this.
  • We should investigate errors on the test suite validation PR before proceeding with the release: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch #37839 (comment)

Thanks!

cc: @Amar3tto @damccorm @Abacn @claudevdm


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the build label Apr 3, 2026
Comment thread .github/workflows/python_dependency_tests.yml Outdated
@tvalentyn
Copy link
Copy Markdown
Contributor Author

R: @Amar3tto

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@tvalentyn
Copy link
Copy Markdown
Contributor Author

tvalentyn commented Apr 3, 2026

We should take a look whether any other tests suites need to be amended to also run during release branch validation.

@Amar3tto Would you have bandwidth to help with this? Thanks!

Also wondering if trigger_all_tests.json should be a part of the github repo like other trigger files we have.

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Apr 3, 2026

We should take a look whether any other tests suites need to be amended to also run during release branch validation.

There is a check enforcing all beam_PreCommit and beam_PostCommit to have this trigger file:

if (paths != null && !paths.contains('release/trigger_all_tests.json') && !fname.toLowerCase().contains('sickbay') && !workflow.name.toLowerCase().contains('disabled')) {

but this specific test did not follow these naming convention

@tvalentyn tvalentyn merged commit 211cd66 into master Apr 3, 2026
4 checks passed
@tvalentyn tvalentyn deleted the tvalentyn-patch-11 branch April 3, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants