Skip to content

Limit global test pipeline options to integration tests #38237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aIbrahiim wants to merge 1 commit into from
Closed

Limit global test pipeline options to integration tests #38237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sdks/python/apache_beam/testing/test_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def __init__(
display_data (Dict[str, Any]): a dictionary of static data associated
with this pipeline that can be displayed when it runs.
timeout (int, optional): Milliseconds to wait for the pipeline to finish.
If the timeout is reached, an AssertionError is raised.
If the timeout is reached, an AssertionError is raised.
Raises:
ValueError: if either the runner or options argument is not
of the expected type.
Expand Down Expand Up @@ -153,8 +153,9 @@ def _parse_test_option_args(self, argv):
default=False,
help='whether not to use test-runner-api')
known, unused_argv = parser.parse_known_args(argv)
test_pipeline_options = known.test_pipeline_options or \
TestPipeline.pytest_test_pipeline_options
test_pipeline_options = known.test_pipeline_options or (
TestPipeline.pytest_test_pipeline_options
if self.is_integration_test else None)
if self.is_integration_test and not test_pipeline_options:
# Skip integration test when argument '--test-pipeline-options' is not
# specified since nose calls integration tests when runs unit test by
Expand Down
Loading