Skip to content

FileBasedSinkTest failure #38284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 2 commits into from
Apr 27, 2026
Merged

FileBasedSinkTest failure #38284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d64e3a3
FileBasedSinkTest failure
derrickaw Apr 24, 2026
ce88a25
revert fileBasedSinkTest change and initialize source and sink if null
derrickaw Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/Lineage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import org.apache.beam.sdk.lineage.LineageOptions;
import org.apache.beam.sdk.metrics.Metrics.MetricsFlag;
import org.apache.beam.sdk.options.PipelineOptions;
import org.apache.beam.sdk.options.PipelineOptionsFactory;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.annotations.VisibleForTesting;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Splitter;
import org.checkerframework.checker.nullness.qual.Nullable;
Expand Down Expand Up @@ -122,16 +123,24 @@ private static Lineage createLineage(PipelineOptions options, LineageDirection d

/** {@link Lineage} representing sources and optionally side inputs. */
public static Lineage getSources() {
return checkNotNull(
sources,
"Lineage not initialized. FileSystems.setDefaultPipelineOptions must be called first.");
Lineage localSources = sources;
if (localSources == null) {
return createDefaultLineage(LineageDirection.SOURCE);
}
return localSources;
}

/** {@link Lineage} representing sinks. */
public static Lineage getSinks() {
return checkNotNull(
sinks,
"Lineage not initialized. FileSystems.setDefaultPipelineOptions must be called first.");
Lineage localSinks = sinks;
if (localSinks == null) {
return createDefaultLineage(LineageDirection.SINK);
}
return localSinks;
}

private static Lineage createDefaultLineage(LineageDirection direction) {
return createLineage(PipelineOptionsFactory.create(), direction);
}

@VisibleForTesting
Expand Down
Loading