Skip to content

update port for jdbc test #38485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 5 commits into from
May 13, 2026
Merged

update port for jdbc test #38485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89b6c8d
increase timeout
derrickaw May 13, 2026
1da89ae
check post commit
derrickaw May 13, 2026
664aff3
try adding back nat for one test case
derrickaw May 13, 2026
f280f57
try getting port instead
derrickaw May 13, 2026
5357c7d
revert time change
derrickaw May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_XVR_Direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"modification": 5
"modification": 1
}
4 changes: 3 additions & 1 deletion sdks/go/test/integration/io/xlang/jdbc/jdbc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import (
"github.com/apache/beam/sdks/v2/go/test/integration/internal/containers"
_ "github.com/go-sql-driver/mysql"
_ "github.com/lib/pq"
"strings"
"github.com/testcontainers/testcontainers-go/wait"
)

Expand Down Expand Up @@ -60,7 +61,8 @@ func setupTestContainer(ctx context.Context, t *testing.T, dbname, username, pas
hostname := "localhost"

dbURL := func(host string, port string) string {
return fmt.Sprintf("postgres://%s:%s@%s:%s/%s?sslmode=disable", username, password, host, port, dbname)
cleanPort := strings.Split(port, "/")[0]
return fmt.Sprintf("postgres://%s:%s@%s:%s/%s?sslmode=disable", username, password, host, cleanPort, dbname)
}
waitStrategy := wait.ForSQL(postgresPort, "postgres", dbURL).WithStartupTimeout(time.Second * 5)

Expand Down
Loading