From ce20d8440f05b5fe624d58834c7c8cca3c26abe2 Mon Sep 17 00:00:00 2001 From: Tobias Kaymak Date: Wed, 13 May 2026 18:09:47 +0000 Subject: [PATCH 1/4] [runners-spark] Spark 4 follow-up: address remaining review comments from #38255 Addresses two trailing review comments left on PR #38255 at the approved/merged head SHA that were never folded in before merge: - Restore the `feature Y added to Java SDK` placeholder line in CHANGES.md Highlights (lost to a rebase). Comment: https://github.com/apache/beam/pull/38255#discussion_r3204237226 - Delete two orphaned `.github/trigger_files/*.json`: - `beam_PreCommit_Java_Spark4_Versions.json`: its workflow YAML was deleted in #38255. - `beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json`: flagged as "not effective yet"; since then, #38478 renamed the associated workflow YAML to `beam_PostCommit_Java_ValidatesRunner_Spark4.yml`, so this trigger JSON is doubly orphaned. Comment: https://github.com/apache/beam/pull/38255#discussion_r3204241059 The renamed workflow YAML stays in place; per the trigger-files convention these JSONs are only added when an author wants to manually trigger a specific PostCommit. --- ...tCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json | 3 --- .github/trigger_files/beam_PreCommit_Java_Spark4_Versions.json | 3 --- CHANGES.md | 1 + 3 files changed, 1 insertion(+), 6 deletions(-) delete mode 100644 .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json delete mode 100644 .github/trigger_files/beam_PreCommit_Java_Spark4_Versions.json diff --git a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json deleted file mode 100644 index c4edaa85a89d..000000000000 --- a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "comment": "Modify this file in a trivial way to cause this test suite to run" -} diff --git a/.github/trigger_files/beam_PreCommit_Java_Spark4_Versions.json b/.github/trigger_files/beam_PreCommit_Java_Spark4_Versions.json deleted file mode 100644 index c4edaa85a89d..000000000000 --- a/.github/trigger_files/beam_PreCommit_Java_Spark4_Versions.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "comment": "Modify this file in a trivial way to cause this test suite to run" -} diff --git a/CHANGES.md b/CHANGES.md index 058e19ea7435..7443799ce39a 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -60,6 +60,7 @@ ## Highlights * New highly anticipated feature X added to Python SDK ([#X](https://github.com/apache/beam/issues/X)). +* New highly anticipated feature Y added to Java SDK ([#Y](https://github.com/apache/beam/issues/Y)). ## I/Os From 13bdb3dd8a1e05ee1a077cc4b3e6f95395c9cc33 Mon Sep 17 00:00:00 2001 From: Tobias Kaymak Date: Wed, 13 May 2026 20:13:28 +0200 Subject: [PATCH 2/4] Update CHANGES.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- CHANGES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.md b/CHANGES.md index 7443799ce39a..67f12636a757 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -61,6 +61,7 @@ * New highly anticipated feature X added to Python SDK ([#X](https://github.com/apache/beam/issues/X)). * New highly anticipated feature Y added to Java SDK ([#Y](https://github.com/apache/beam/issues/Y)). +* Spark 4 runner added to Java SDK ([#38255](https://github.com/apache/beam/pull/38255)). ## I/Os From 9ec1538aa658de8dcabf0ea0c770817758b4c9c7 Mon Sep 17 00:00:00 2001 From: Tobias Kaymak Date: Wed, 13 May 2026 18:18:14 +0000 Subject: [PATCH 3/4] Fix CHANGES.md URL: /pull/N -> /issues/N for validateChanges --- CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 67f12636a757..2bf4e50ac250 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -61,7 +61,7 @@ * New highly anticipated feature X added to Python SDK ([#X](https://github.com/apache/beam/issues/X)). * New highly anticipated feature Y added to Java SDK ([#Y](https://github.com/apache/beam/issues/Y)). -* Spark 4 runner added to Java SDK ([#38255](https://github.com/apache/beam/pull/38255)). +* Spark 4 runner added to Java SDK ([#38255](https://github.com/apache/beam/issues/38255)). ## I/Os From 0e8d2b88e064b12cac38711d8c8e28a2e2e3f8f3 Mon Sep 17 00:00:00 2001 From: Tobias Kaymak Date: Wed, 13 May 2026 21:43:00 +0200 Subject: [PATCH 4/4] Update CHANGES.md Co-authored-by: Yi Hu --- CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 2bf4e50ac250..ca911e52a7ad 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -61,7 +61,7 @@ * New highly anticipated feature X added to Python SDK ([#X](https://github.com/apache/beam/issues/X)). * New highly anticipated feature Y added to Java SDK ([#Y](https://github.com/apache/beam/issues/Y)). -* Spark 4 runner added to Java SDK ([#38255](https://github.com/apache/beam/issues/38255)). +* Spark 4 runner support for Java SDK ([#38255](https://github.com/apache/beam/issues/38255)). ## I/Os