Fix Dataflow archetype missing API client dependency

[aIbrahiim]

Fixes: #30505

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a missing dependency issue in the Dataflow Maven archetypes. By explicitly including the google-api-services-dataflow library in both the standard examples and the GCP BOM examples, it ensures that projects generated from these archetypes have the necessary runtime dependencies for Dataflow operations.

Highlights

• Dependency Update: Added the google-api-services-dataflow dependency to the Dataflow and GCP BOM Maven archetypes.
• Configuration Update: Updated build.gradle files to include the versioning for the new Dataflow API service dependency.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the google-api-services-dataflow dependency to the Maven archetypes for both standard and GCP BOM examples. The changes include updating the build.gradle files to pass the Dataflow API version and modifying the archetype pom.xml templates to include the dependency with a runtime scope. I have no feedback to provide.

[github-actions]

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[Abacn]

this dependency should present transitively:

beam/runners/google-cloud-dataflow-java/build.gradle

Line 105 in 6e23bc1

implementation library.java.google_api_services_dataflow

There is something wrong if it doesn't

[aIbrahiim]

this dependency should present transitively:

beam/runners/google-cloud-dataflow-java/build.gradle

Line 105 in 6e23bc1

implementation library.java.google_api_services_dataflow

There is something wrong if it doesn't

yes right as the runner does declare google-api-services-dataflow in build.gradle, and it shows up in the generated POM. I dug into it a bit more though: the published snapshot POM is invalid (opentelemetry-context has no version). Maven then says transitive deps from the runner aren’t available, and dependency:tree with only the runner jar didnt pull in google-api-services-dataflow so adding it explicitly in the archetype fixes that for generated quickstarts so i suggest keeping the archtype change for now and i will be working on fixing runner POM generation so BOM-managed deps get proper versions in the published POM then we could drop the duplicate from the archetype @Abacn

[Abacn]

The published snapshot POM is invalid (opentelemetry-context has no version).

Nice finding. Introduced in #36962. We should fix the dependency (add a version) cc: @stankiewicz

Interestingly this is tolerated by Gradle but not Maven, so we only catch this in the maven archetype test

[Abacn]

It's a real breakage. Essentially users using maven to run Beam pipeline will find the dependency of dataflow-runner breaking. I doubt that add this dependency only is not sufficient

[Abacn]

I got a fix and is testing

update: #38518

[Abacn]

oops sorry, merged wrong PR