Revert "[Java Portable SDK] Configure JVM so that it exits upon OutOfMemoryError originating in JVM."#38567
Conversation
…MemoryEr…" This reverts commit 37ae1ff.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous change that configured the JVM to exit upon encountering an OutOfMemoryError. The reversion is necessary to resolve compatibility issues with the Dataflow Vertical worker scaling feature. Additionally, the PR includes a minor refactor to the heap dump configuration logic to improve code cleanliness. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the Java SDK container boot configuration in sdks/java/container/boot.go. The changes include removing the -XX:+ExitOnOutOfMemoryError flag from the default JVM arguments and refactoring the logic for enabling heap dumps on OutOfMemoryError to be more direct by eliminating an intermediate boolean variable. There are no review comments to address, and I have no feedback to provide.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
We should cherry-pick to the release branch and move to RC 2 - I'll update the voting thread cc/ @Amar3tto |
…MemoryEr…" (apache#38567) This reverts commit 37ae1ff.
2 participants
Reverts #37764
This breaks Dataflow Vertical worker scaling feature. It is planned to be remerged at a later point once that has been fixed.