-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Enforce Google Maven Mirror on CI environments #38586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
88f33ae
Implement Maven Central mirroring in CI environments
shunping 197963a
Fix subproject buildscript classpath resolution for beam-test-gha usi…
shunping 1bf83f0
Remove duplicated definition.
shunping 8663161
Discard the new settings file in buildSrc first.
shunping 99d5021
Fix compilation error.
shunping File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,20 @@ | |
| import com.gradle.enterprise.gradleplugin.internal.extension.BuildScanExtensionWithHiddenFeatures | ||
|
|
||
| pluginManagement { | ||
| val mavenCentralMirrorUrl = settings.providers.gradleProperty("mavenCentralMirrorUrl").orNull | ||
| val isCi = System.getenv("GITHUB_ACTIONS") != null || System.getenv("JENKINS_HOME") != null | ||
| val useMirror = isCi && !mavenCentralMirrorUrl.isNullOrBlank() | ||
|
|
||
| if (useMirror) { | ||
| logger.lifecycle("Running in CI. Mirroring Maven Central repositories via Google Maven Mirror.") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This log appears multiple times. Logging here once should suffice
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's keep them for now. We can remove them later if the infra problem is resolved. |
||
| } | ||
|
|
||
| repositories { | ||
| if (useMirror) { | ||
| maven { url = uri(mavenCentralMirrorUrl!!) } | ||
| } | ||
| gradlePluginPortal() | ||
| } | ||
| plugins { | ||
| id("org.javacc.javacc") version "4.0.3" // enable the JavaCC parser generator | ||
| } | ||
|
|
@@ -28,7 +42,6 @@ plugins { | |
| id("com.gradle.common-custom-user-data-gradle-plugin") version "2.6.0" | ||
| } | ||
|
|
||
|
|
||
| // JENKINS_HOME and BUILD_ID set automatically during Jenkins execution | ||
| val isJenkinsBuild = arrayOf("JENKINS_HOME", "BUILD_ID").all { System.getenv(it) != null } | ||
| // GITHUB_REPOSITORY and GITHUB_RUN_ID set automatically during Github Actions run | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.