Support MAP type in RowJson and fix datetime parsing with spaces - #38865
Conversation
|
R: @Abacn |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the RowJson utility within the Apache Beam Java SDK by introducing support for MAP types, ensuring that Rows containing maps can be correctly serialized and deserialized. Furthermore, it improves the robustness of datetime parsing by accommodating datetime strings that include spaces, preventing potential failures during data processing. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for the MAP type in RowJson serialization and deserialization, ensuring map keys are strings, and updates RowJsonValueExtractors to parse datetime strings containing spaces. The review feedback highlights two important improvements: replacing only the first space in datetime strings using replaceFirst to avoid corrupting timezone offsets, and using ImmutableMap instead of HashMap in tests to guarantee deterministic key ordering and prevent flaky tests.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
2 participants
Extends Beam's JSON serialization utility (
RowJson) to supportMaptypes, enabling seamless conversion of Rows containing map fields to and from JSON.The Problem
While Beam's
Rowschema supportsMapfields, theRowJsonutility (which handles Row-to-JSON and JSON-to-Row conversions) did not have support for maps. Attempting to serialize or deserialize a Row with aMapfield would result in unsupported type exceptions, blocking pipelines that rely on JSON serialization (such as those interfacing with external systems or using certain SQL operators).The Fix
RowJsonSerializer. When encountering aMapfield, we now serialize it as a JSON object, recursively serializing the map's values based on their schema type.MapExtractorto handle deserialization. It extracts JSON objects and reconstructs them into JavaMapinstances, converting keys to strings and recursively extracting values to match the expected BeamFieldTypeof the map's values.Map<String, Integer>).