SQL Physical Operator Fixes and Enhancements - #38867
Closed
damccorm wants to merge 2 commits into
Closed
Conversation
damccorm
force-pushed
the
feature/sql-physical-opt-fixes
branch
from
June 9, 2026 15:31
51756eb to
7158788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes critical planning and execution bugs in Beam SQL, specifically addressing Volcano planner convergence failures and correlated scalar subquery execution.
1. Volcano Planner Convergence in Windowing & Calculations
OVERclauses) or subqueries, the Volcano planner would often fail to find a physical plan, throwingCannotPlanExceptiondue to "infinite cost". This happened becauseBeamWindowRelandBeamCalcRelcost estimation relied onBeamSqlRelUtils.getNodeStats(input). During the Volcano search, the input is often an unoptimizedRelSubset. CallinggetNodeStatson these subsets returnedUNKNOWN(infinite cost), creating a recursion loop and preventing the planner from converging on a valid physical path.BeamWindowRel.computeSelfCostandBeamCalcRel.computeSelfCostto usemq.getRowCount(this.input)instead ofgetNodeStatswhen estimating row counts during planning. This is Volcano-safe and allows the planner to successfully estimate costs and converge.2. Correlated Subquery Execution (
SINGLE_VALUEAggregation)SINGLE_VALUEaggregation to guarantee at most one row is returned. Beam SQL's physical execution layer was missing the mapping for theSINGLE_VALUEoperator, leading to runtime translation failures.SINGLE_VALUEaggregation operator in the physical layer, mapping it to a combiner that asserts at most one element is present and returns it.BeamSqlDslAggregationTestverifying correlated scalar subqueries execute correctly.