Skip to content

Add metric for Kafka offset commit failures #38889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrmccluskey merged 2 commits into from
Jul 21, 2026
Merged

Add metric for Kafka offset commit failures #38889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4bbb92
Add metric for Kafka offset commit failures
Kriti-dev07 Jun 10, 2026
d4f2280
Apply suggestions from code review
jrmccluskey Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaCommitOffset.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
import org.apache.beam.sdk.coders.KvCoder;
import org.apache.beam.sdk.coders.VarLongCoder;
import org.apache.beam.sdk.coders.VoidCoder;
import org.apache.beam.sdk.metrics.Counter;
import org.apache.beam.sdk.metrics.Metrics;
import org.apache.beam.sdk.schemas.NoSuchSchemaException;
import org.apache.beam.sdk.transforms.DoFn;
import org.apache.beam.sdk.transforms.MapElements;
Expand Down Expand Up @@ -62,6 +64,9 @@ public class KafkaCommitOffset<K, V>

static class CommitOffsetDoFn extends DoFn<KV<KafkaSourceDescriptor, Long>, Void> {
private static final Logger LOG = LoggerFactory.getLogger(CommitOffsetDoFn.class);
private static final Counter COMMIT_FAILURES =
Metrics.counter(CommitOffsetDoFn.class, "commit-failures");

private final Map<String, Object> consumerConfig;
private final SerializableFunction<Map<String, Object>, Consumer<byte[], byte[]>>
consumerFactoryFn;
Expand All @@ -85,6 +90,7 @@ public void processElement(@Element KV<KafkaSourceDescriptor, Long> element) {
element.getKey().getTopicPartition(),
new OffsetAndMetadata(element.getValue() + 1)));
} catch (Exception e) {
COMMIT_FAILURES.inc();
// TODO: consider retrying.
LOG.warn("Getting exception when committing offset: {}", e.getMessage());
}
Expand Down
Loading