Skip to content

Exclude testSideInputNotReadyTimer from Spark batch suites #38939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
Jun 12, 2026
+4 −0
Merged

Exclude testSideInputNotReadyTimer from Spark batch suites #38939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions runners/spark/job-server/spark_job_server.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ def portableValidatesRunnerTask(String name, boolean streaming, boolean docker,
excludeTestsMatching 'org.apache.beam.sdk.transforms.FlattenTest.testFlattenWithDifferentInputAndOutputCoders2'
// TODO(https://github.com/apache/beam/issues/31231)
excludeTestsMatching 'org.apache.beam.sdk.transforms.RedistributeTest.testRedistributePreservesMetadata'
// Spark does not support side inputs in timers (added in #38363)

@gemini-code-assist gemini-code-assist Bot Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure this test exclusion is tracked and eventually resolved, please create a GitHub issue and reference it with a TODO comment, following the pattern used elsewhere in this file.

        // TODO(https://github.com/apache/beam/issues/XXXXX) Spark does not support side inputs in timers

excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoTest$StateTests.testSideInputNotReadyTimer'
for (String test : sickbayTests) {
excludeTestsMatching test
}
Expand Down
2 changes: 2 additions & 0 deletions runners/spark/spark_runner.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,8 @@ def validatesRunnerBatch = tasks.register("validatesRunnerBatch", Test) {
excludeTestsMatching 'org.apache.beam.sdk.transforms.RedistributeTest.testRedistributePreservesMetadata'
// TODO(https://github.com/apache/beam/issues/32021)
excludeTestsMatching 'org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests.testBoundedSourceMetricsInSplit'
// Spark does not support side inputs in timers (added in #38363)

@gemini-code-assist gemini-code-assist Bot Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Please use a TODO comment with a GitHub issue link to track the enablement of this test, consistent with other test exclusions in this file.

    // TODO(https://github.com/apache/beam/issues/XXXXX) Spark does not support side inputs in timers

excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoTest$StateTests.testSideInputNotReadyTimer'
}
}

Expand Down
Loading