Skip to content

Disable public IP for Dataflow Python and Go Validate runner tests#38990

Merged
Abacn merged 1 commit into
apache:masterfrom
Abacn:disable-public-ips
Jun 17, 2026
Merged

Disable public IP for Dataflow Python and Go Validate runner tests#38990
Abacn merged 1 commit into
apache:masterfrom
Abacn:disable-public-ips

Conversation

@Abacn

@Abacn Abacn commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here

Python, Go counterpart of Java change: #38424

Checked in GCP console the GCE VM of the Dataflow jobs now do not have public ip


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn Abacn force-pushed the disable-public-ips branch from 489739b to 41fcd43 Compare June 17, 2026 01:41
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.72%. Comparing base (2c53494) to head (41fcd43).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #38990   +/-   ##
=========================================
  Coverage     57.71%   57.72%           
  Complexity    13028    13028           
=========================================
  Files          2513     2513           
  Lines        261375   261406   +31     
  Branches      10722    10722           
=========================================
+ Hits         150863   150900   +37     
+ Misses       104795   104789    -6     
  Partials       5717     5717           
Flag Coverage Δ
python 79.28% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Abacn Abacn marked this pull request as ready for review June 17, 2026 14:00
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Dataflow integration testing infrastructure for Python and Go to disable public IP usage. This change aligns with security best practices by ensuring that runners do not rely on public IP addresses during validation tests. The implementation involves adding support for additional pipeline options in the Python integration test script and updating the corresponding Gradle tasks to enforce the --no_use_public_ips flag.

Highlights

  • Dataflow Configuration: Disabled public IP usage for Dataflow Python and Go ValidatesRunner tests by passing the --no_use_public_ips flag.
  • Python Scripting Updates: Updated run_integration_test.sh to support an --additional_opts flag, allowing pipeline options to be appended to existing configurations.
  • Gradle Integration: Updated Go and Python Gradle test suites to include the new public IP restriction in their integration test execution.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the --additional_opts flag to the Python integration test script to allow appending pipeline options, and configures Go and Python Dataflow test suites to run with --no_use_public_ips. A bug was identified in the shell script where --additional_opts is only appended when --pipeline_opts is empty, which would cause it to be silently ignored if --pipeline_opts is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sdks/python/scripts/run_integration_test.sh
@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn

Abacn commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

R: @stankiewicz

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn merged commit ee92a55 into apache:master Jun 17, 2026
114 of 116 checks passed
@Abacn Abacn deleted the disable-public-ips branch June 17, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants