cancel user code with interruption after timeout - #39018
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the robustness of user code execution within the RequestResponse IO module by ensuring that futures are properly cancelled upon encountering a timeout or interruption. This prevents potential resource leaks and ensures that long-running tasks are terminated as expected when they exceed their allocated time. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Call.java to cancel the running future when a TimeoutException or InterruptedException is caught. The reviewer suggests restoring the thread's interrupted status when handling InterruptedException to ensure upstream callers are aware of the interruption.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| try { | ||
| return future.get(timeout.getMillis(), TimeUnit.MILLISECONDS); | ||
| } catch (TimeoutException | InterruptedException e) { | ||
| future.cancel(true); |
There was a problem hiding this comment.
When catching InterruptedException, the interrupted status of the thread is cleared. It is a best practice to restore the interrupted status by calling Thread.currentThread().interrupt() so that upstream callers or the thread pool runner are aware of the interruption.
| future.cancel(true); | |
| future.cancel(true); | |
| if (e instanceof InterruptedException) { | |
| Thread.currentThread().interrupt(); | |
| } |
|
I noticed this since the test was taking the sleep timeout even when the user processing timeout was applied. It seems that we interrupt the user setup/teardown but not the processing. Was this intended? |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
@scwhittle Thank you for telling me about this. When I wrote this I was new to this feature in Java and then context switched to another higher priority. Thank you, again. |
2 participants
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.