Skip to content

cancel user code with interruption after timeout #39018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damondouglas merged 1 commit into from
Jun 18, 2026
Merged

cancel user code with interruption after timeout #39018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ public ResponseT call(RequestT request) throws UserCodeExecutionException {
try {
return future.get(timeout.getMillis(), TimeUnit.MILLISECONDS);
} catch (TimeoutException | InterruptedException e) {
future.cancel(true);

@gemini-code-assist gemini-code-assist Bot Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When catching InterruptedException, the interrupted status of the thread is cleared. It is a best practice to restore the interrupted status by calling Thread.currentThread().interrupt() so that upstream callers or the thread pool runner are aware of the interruption.

Suggested change
future.cancel(true);
future.cancel(true);
if (e instanceof InterruptedException) {
Thread.currentThread().interrupt();
}

throw new UserCodeTimeoutException(e);
} catch (ExecutionException e) {
parseAndThrow(future, e);
Expand Down
Loading