[ReduceFnRunner] Fix Prefetches - #39082
Conversation
arunpandianp
commented
Jun 24, 2026
- Add a prefetch for CombinedMetadata
- Prefetch ReduceFn using renamedContext instead of directContext. This improves prefetching on merging windows
1. Add a prefetch for CombinedMetadata 2. Prefetch ReduceFn using renamedContext instead of directContext. This improves prefetching on merging windows
|
R: @scwhittle |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the prefetching strategy within the ReduceFnRunner to reduce latency during window merging. By refining the context used for state access and ensuring necessary metadata is prefetched, the runner can handle state operations more efficiently. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Code Review
This pull request updates the prefetchOnTrigger method in ReduceFnRunner.java to prefetch the metadata tag from the direct context state and switches the reduceFn.prefetchOnTrigger call to use the renamed context state instead of the direct context state. There are no review comments to address, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
cc: @stankiewicz |
1. Add a prefetch for CombinedMetadata 2. Prefetch ReduceFn using renamedContext instead of directContext. This improves prefetching on merging windows
1. Add a prefetch for CombinedMetadata 2. Prefetch ReduceFn using renamedContext instead of directContext. This improves prefetching on merging windows