Fix JsonToRow swallowing downstream errors when runners fuse transforms. - #39098
Conversation
Separate JSON parsing from MultiOutputReceiver output in ParseWithError so exceptions from fused downstream consumers are not misreported as parse failures. Fixes apache#20935.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug in the JsonToRow transform where exceptions originating from fused downstream consumers were being incorrectly caught and misreported as JSON parsing failures. By decoupling the parsing logic from the output emission, the fix ensures that only actual parsing errors are routed to the dead-letter output, while downstream processing failures are allowed to propagate as expected. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the JsonToRow transform to prevent downstream exceptions from being caught and incorrectly handled as JSON parsing errors. This is done by moving the output emission outside of the try-catch block. A unit test is also added to verify this behavior. The reviewer identified a potential serialization issue in the new test where an anonymous inner class DoFn captures the non-serializable test class, and suggested using MapElements with a lambda expression instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Avoid anonymous DoFn capturing the non-serializable test instance so the test is safe on runners that enforce DoFn serialization.
2879145 to
0bad579
Compare
Use a static DoFn to avoid serialization issues, set row schema on the downstream transform, and tag the test with ValidatesRunner so it can run via Dataflow validatesRunner tasks. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Rebase onto current master (1141 commits behind) and remove ValidatesRunner category so the regression test only runs on DirectRunner needsRunnerTests. Suppress UnusedVariable on ThrowingDownstreamDoFn for Error Prone. Co-authored-by: Cursor <cursoragent@cursor.com>
|
thanks, this looks good, will merge once tests are green. |
…ms. (apache#39098) * Fix JsonToRow swallowing downstream errors when runners fuse transforms. Separate JSON parsing from MultiOutputReceiver output in ParseWithError so exceptions from fused downstream consumers are not misreported as parse failures. Fixes apache#20935. * Address review: use MapElements in JsonToRow regression test. Avoid anonymous DoFn capturing the non-serializable test instance so the test is safe on runners that enforce DoFn serialization. * Fix JsonToRow regression test for runner integration suites. Use a static DoFn to avoid serialization issues, set row schema on the downstream transform, and tag the test with ValidatesRunner so it can run via Dataflow validatesRunner tasks. Co-authored-by: Cursor <cursoragent@cursor.com> * Merge apache/beam master and fix JsonToRowTest for CI. Rebase onto current master (1141 commits behind) and remove ValidatesRunner category so the regression test only runs on DirectRunner needsRunnerTests. Suppress UnusedVariable on ThrowingDownstreamDoFn for Error Prone. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
…ms. (apache#39098) * Fix JsonToRow swallowing downstream errors when runners fuse transforms. Separate JSON parsing from MultiOutputReceiver output in ParseWithError so exceptions from fused downstream consumers are not misreported as parse failures. Fixes apache#20935. * Address review: use MapElements in JsonToRow regression test. Avoid anonymous DoFn capturing the non-serializable test instance so the test is safe on runners that enforce DoFn serialization. * Fix JsonToRow regression test for runner integration suites. Use a static DoFn to avoid serialization issues, set row schema on the downstream transform, and tag the test with ValidatesRunner so it can run via Dataflow validatesRunner tasks. Co-authored-by: Cursor <cursoragent@cursor.com> * Merge apache/beam master and fix JsonToRowTest for CI. Rebase onto current master (1141 commits behind) and remove ValidatesRunner category so the regression test only runs on DirectRunner needsRunnerTests. Suppress UnusedVariable on ThrowingDownstreamDoFn for Error Prone. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
2 participants
Separate JSON parsing from MultiOutputReceiver output in ParseWithError so exceptions from fused downstream consumers are not misreported as parse failures. Fixes #20935.
Please add a meaningful description for your change here
Fixes a bug in
JsonToRow.withExceptionReporting()where exceptions from fused downstream transforms could be caught and misreported as JSON parse failures in the dead-letter output.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.