Skip to content

Fix typos in ExecutorServiceParallelExecutor.java - #39123

Merged
shunping merged 1 commit into
apache:masterfrom
shunping:fix-typos
Jun 26, 2026
Merged

Fix typos in ExecutorServiceParallelExecutor.java#39123
shunping merged 1 commit into
apache:masterfrom
shunping:fix-typos

Conversation

@shunping

@shunping shunping commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Follow-up with #39096

Same fix has been applied to 2.75 release branch: #39115

@shunping

Copy link
Copy Markdown
Collaborator Author

r: @Abacn

@shunping
shunping marked this pull request as ready for review June 26, 2026 10:23
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the clarity and accuracy of error reporting within the ExecutorServiceParallelExecutor. By refining the exception message and fixing formatting issues, it ensures that developers receive more precise diagnostic information during executor shutdown failures.

Highlights

  • Error message update: Updated the error message text to accurately reflect that the error occurred during executor shutdown rather than general pipeline execution.
  • String formatting fix: Corrected the newline character escaping in the exception message to ensure proper formatting when reporting errors.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the error message in ExecutorServiceParallelExecutor.java when an exception occurs during executor shutdown. It changes the message text to correctly reflect that the error occurred during executor shutdown rather than pipeline execution, and fixes double-escaped newline characters (\\n to \n). There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@shunping
shunping merged commit b642c5c into apache:master Jun 26, 2026
20 checks passed
@shunping
shunping deleted the fix-typos branch June 26, 2026 13:33
ash6898 pushed a commit to ash6898/beam that referenced this pull request Jun 28, 2026
ash6898 pushed a commit to ash6898/beam that referenced this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants