IcerbergIO Load test and benchmarking by Amar3tto · Pull Request #39270 · apache/beam

Amar3tto · 2026-07-09T10:57:56Z

Successful run: https://github.com/apache/beam/actions/runs/29006124448/job/86078012033
Read Dataflow Job: 2026-07-09_02_11_56-9909184907203270916
Write Dataflow Job: 2026-07-09_02_00_15-6048170378328054140

Changes:

Moved the next classes from it.gcp to it.common:
- DefaultPipelineLauncher and AbstractPipelineLauncher
- LoadTestBase
- Resource managers and Artifact utils
Implemented Load test for IcebergIO Batch Read/Write
Added IcebergIO Looker diagrams with metrics to the website

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

gemini-code-assist · 2026-07-09T10:58:27Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive load testing and benchmarking for IcebergIO. It includes a significant refactoring of existing integration test utilities to promote code reuse by moving common components into a shared module. Additionally, it adds support for IcebergIO performance tracking on the project's website, providing visibility into read and write performance metrics.

Highlights

Refactoring: Moved common integration test utilities from the gcp module to a shared common module to improve code reuse.
Load Testing: Implemented new load tests for IcebergIO Batch Read and Write operations.
Documentation and Metrics: Added IcebergIO performance metrics to the project website, including new Looker diagrams for visualization.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/beam_PostCommit_Java_IO_Performance_Tests.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces integration and performance tests for IcebergIO (IcebergIOLT), along with its corresponding Gradle tasks, website documentation, and Looker metrics configurations. Additionally, it reorganizes the integration testing framework by moving common test utilities (such as load/stress test base classes, artifact clients, and resource managers) from the GCP-specific module to a shared common module under the org.apache.beam.it.common package, updating dependencies and imports across several modules. Regarding the feedback, a performance issue was identified in the new IcebergIOLT test where a Random object is instantiated for every processed element, which can cause significant CPU and garbage collection overhead; it is recommended to reuse a single transient Random instance and update its seed instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

damccorm

Thanks - just had a couple of questions

github-actions · 2026-07-10T19:03:01Z

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Amar3tto · 2026-07-20T17:09:06Z

@damccorm could you please re-review

damccorm · 2026-07-20T17:40:28Z

+  resolutionStrategy.capabilitiesResolution.withCapability("org.lz4:lz4-java") {
+    select("at.yawk.lz4:lz4-java:1.10.2")
+  }
+}


Is this change intentional?

Yes, because of moving some dependencies to common, there was a lz4 conflict

github-actions · 2026-07-20T18:14:40Z

Assigning reviewers:

R: @liferoad for label build.
R: @kennknowles for label website.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

damccorm

Thanks

Amar3tto added 4 commits July 7, 2026 15:38

Refactor LoadTestBase

22b2f38

Refactor DefaultPipelineLauncher

875cfd1

Add IcebergIOLT

5312b03

Add looker metrics for IcebergIO

7fb0778

Amar3tto requested a review from damccorm July 9, 2026 10:57

github-actions Bot added build website infra labels Jul 9, 2026

gemini-code-assist Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread it/iceberg/src/test/java/org/apache/beam/it/iceberg/IcebergIOLT.java

damccorm reviewed Jul 10, 2026

View reviewed changes

Comment thread it/common/src/main/java/org/apache/beam/it/common/bigquery/BigQueryResourceManager.java

Comment thread it/common/src/main/resources/test-artifact.json

Comment thread it/iceberg/src/test/java/org/apache/beam/it/iceberg/IcebergIOLT.java

Refactoring

9432ace

Amar3tto requested a review from damccorm July 14, 2026 12:02

github-actions Bot added the Next Action: Reviewers label Jul 14, 2026

Fix conflict

ab142e9

damccorm reviewed Jul 20, 2026

View reviewed changes

Amar3tto requested a review from damccorm July 20, 2026 20:38

damccorm approved these changes Jul 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

IcerbergIO Load test and benchmarking#39270

IcerbergIO Load test and benchmarking#39270
Amar3tto wants to merge 6 commits into
masterfrom
icerbergio-benchmark

Amar3tto commented Jul 9, 2026

Uh oh!

gemini-code-assist Bot commented Jul 9, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

damccorm left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

Amar3tto commented Jul 20, 2026

Uh oh!

damccorm Jul 20, 2026

Uh oh!

Amar3tto Jul 20, 2026

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

damccorm left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Amar3tto commented Jul 9, 2026

GitHub Actions Tests Status (on master branch)

Uh oh!

gemini-code-assist Bot commented Jul 9, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

damccorm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

Amar3tto commented Jul 20, 2026

Uh oh!

damccorm Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

Amar3tto Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

damccorm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants