Skip to content

Fix BeamRowWrapperTest microsecond precision flake #39287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmedabu98 merged 1 commit into from
Jul 13, 2026
Merged

Fix BeamRowWrapperTest microsecond precision flake #39287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/BeamRowWrapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ public class BeamRowWrapperTest {
Types.NestedField.required(1, "nested_int", Types.IntegerType.get()))),
Types.NestedField.required(14, "pass_through_field", Types.IntegerType.get()));
private static final UUID TEST_UUID = UUID.randomUUID();
private static final Instant TEST_MICROS_INSTANT =
Instant.ofEpochSecond(1_609_459_200L, 123_456_000);
Comment thread
bvolpato marked this conversation as resolved.
private static final Row NESTED_ROW = Row.withSchema(NESTED_BEAM_SCHEMA).addValue(999).build();
private static final Row ROW =
Row.withSchema(BEAM_SCHEMA)
Expand All @@ -99,7 +101,7 @@ public class BeamRowWrapperTest {
.array(),
new BigDecimal("123.45"),
org.joda.time.Instant.now(),
Instant.now(),
TEST_MICROS_INSTANT,
LocalDateTime.now(ZoneId.systemDefault()),
LocalDate.now(ZoneId.systemDefault()),
LocalTime.now(ZoneId.systemDefault()),
Expand Down Expand Up @@ -180,10 +182,7 @@ public void testDateTimeConversion() {

@Test
public void testMicrosInstantLogicalTypeConversion() {
Instant javaInstant = ROW.getLogicalTypeValue(7, Instant.class);
long expectedMicrosInstant =
TimeUnit.SECONDS.toMicros(javaInstant.getEpochSecond()) + javaInstant.getNano() / 1000;
assertEquals(expectedMicrosInstant, (long) WRAPPER.get(7, Long.class));
assertEquals(1_609_459_200_123_456L, (long) WRAPPER.get(7, Long.class));
Comment thread
bvolpato marked this conversation as resolved.
}

@Test
Expand Down
Loading