Add JVM --add-opens flags for Flink PVR on Java 21#39303
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces configuration changes to ensure compatibility with Java 21 for Flink Portable Runner (PVR) tests. By dynamically adding required JVM module-opening flags and security manager settings, it resolves runtime issues encountered when executing these tests on newer Java versions. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures JVM arguments (such as --add-opens and security manager permissions) for Flink Job Server tasks when running on Java 17 or higher, and updates the setup task to pass these arguments. The review feedback suggests using Gradle's built-in JavaVersion.toVersion() helper for a more robust Java version check, and using the standard jvmArgs(...) method instead of the += operator to safely append JVM arguments to tasks.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| def testJavaVer = project.findProperty('testJavaVersion') ? (project.property('testJavaVersion') as int) : JavaVersion.current().majorVersion.toInteger() | ||
| if (testJavaVer >= 17) { |
There was a problem hiding this comment.
Instead of manually parsing the Java version string to an integer (which can be fragile depending on the format of testJavaVersion), you can use Gradle's built-in JavaVersion.toVersion() helper. This is much more robust and idiomatic.
def javaVersion = JavaVersion.toVersion(project.findProperty('testJavaVersion') ?: JavaVersion.current())
if (javaVersion.isJava17Compatible()) {
|
|
||
| [validatesPortableRunnerDocker, validatesPortableRunnerBatchDataSet, validatesPortableRunnerBatch, validatesPortableRunnerStreaming, validatesPortableRunnerStreamingCheckpoint].each { task -> | ||
| task.configure { | ||
| jvmArgs += flinkJobServerJvmArgs() |
There was a problem hiding this comment.
Using jvmArgs(...) is the standard and safer Gradle DSL method to append JVM arguments to a task, rather than using the += operator which can fail if jvmArgs is not pre-initialized.
jvmArgs(flinkJobServerJvmArgs())
|
Assigning reviewers: R: @damccorm added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @Abacn Would you mind taking a look here? |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
3 participants
Fixes: #39264
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.