Skip to content

Rename changelog scanner #39304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derrickaw merged 1 commit into from
Jul 13, 2026
Merged

Rename changelog scanner #39304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/cdc/ChangelogScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
import org.apache.beam.sdk.values.TupleTag;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Iterables;
import org.apache.iceberg.AddedRowsScanTask;
import org.apache.iceberg.BaseIncrementalChangelogScan;
import org.apache.iceberg.BeamBaseIncrementalChangelogScan;
import org.apache.iceberg.ChangelogScanTask;
import org.apache.iceberg.DataFile;
import org.apache.iceberg.DataOperations;
Expand Down Expand Up @@ -230,7 +230,7 @@ public void process(@Element Long snapshotId, MultiOutputReceiver out) throws IO
// TODO(ahmedabu98): replace this with table.newIncrementalChangelogScan() when
// https://github.com/apache/iceberg/pull/14264/ gets merged and released.
IncrementalChangelogScan scan =
new BaseIncrementalChangelogScan(table)
new BeamBaseIncrementalChangelogScan(table)
.toSnapshot(snapshotId)
.project(scanConfig.getProjectedSchema());
if (fromSnapshotId != null) {
Expand Down
10 changes: 5 additions & 5 deletions ...iceberg/BaseIncrementalChangelogScan.java → ...erg/BeamBaseIncrementalChangelogScan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
* Copied over from <a href="https://github.com/apache/iceberg/pull/14264/">Iceberg PR #14264</a>.
*/
@SuppressWarnings("nullness")
public class BaseIncrementalChangelogScan
public class BeamBaseIncrementalChangelogScan
extends BaseIncrementalScan<
IncrementalChangelogScan, ChangelogScanTask, ScanTaskGroup<ChangelogScanTask>>
implements IncrementalChangelogScan {
Expand All @@ -80,20 +80,20 @@ private static DeleteFileIndex createEmptyInstance() {
}
}

private static final Logger LOG = LoggerFactory.getLogger(BaseIncrementalChangelogScan.class);
private static final Logger LOG = LoggerFactory.getLogger(BeamBaseIncrementalChangelogScan.class);

public BaseIncrementalChangelogScan(Table table) {
public BeamBaseIncrementalChangelogScan(Table table) {
this(table, table.schema(), TableScanContext.empty());
}

private BaseIncrementalChangelogScan(Table table, Schema schema, TableScanContext context) {
private BeamBaseIncrementalChangelogScan(Table table, Schema schema, TableScanContext context) {
super(table, schema, context);
}

@Override
protected IncrementalChangelogScan newRefinedScan(
Table newTable, Schema newSchema, TableScanContext newContext) {
return new BaseIncrementalChangelogScan(newTable, newSchema, newContext);
return new BeamBaseIncrementalChangelogScan(newTable, newSchema, newContext);
}

// Private fields to track build call count and cache (accessed via package-private methods for
Expand Down
Loading