Isolate Python 3.14 SDK snapshot publishes from the main matrix#39436
Isolate Python 3.14 SDK snapshot publishes from the main matrix#39436aIbrahiim wants to merge 2 commits into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Assigning reviewers: R: @Abacn for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
This change made some version specific logic which adds maintenance burden in the future. I see currently the workflow is green and work fine ======== I may have missed something, but currently the workflow already runs each python version in different matrix: https://github.com/apache/beam/actions/runs/29992852197 as one can see, Python 3.14 and 3.14 distroless have they own job: https://github.com/apache/beam/actions/runs/29992852197/job/89159380239 https://github.com/apache/beam/actions/runs/29992852197/job/89159380379 ======== If the concern is on postcommit tests, we can make Python ARM PostCommits to use prebuild containers (gcr.io/apache-beam-testing/beam_python*_sdk:latest) to save time. |
Thank you for the feedback @Abacn okay right each Python version already has its own matrix job, I may have overstated that part and in this PR I was trying to only change when py314 runs so today everything starts together and shares the same runners, and this would make py314 wait until the main matrix finishes But I got it as this adds version-specific logic and extra maintenance, and if Snapshots is already green, the benefit is pretty small I will also consider reusing the prebuilt images and check in a new PR. |
|
@Abacn |
Follow up to the Python 3.14 CI slowness work (#39401 / #39402): py314 multiarch snapshot builds are much slower and contend with other snapshot matrix jobs on the self-hosted pool
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.