Fix flaky AsyncWrapper reset_state test on Python 3.14 - #39521
Merged
tvalentyn merged 1 commit intoJul 28, 2026
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
bvolpato
changed the title
bvolpato
marked this pull request as ready for review
July 28, 2026 05:20
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
|
Assigning reviewers: R: @jrmccluskey for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39456.
Summary
The deadlock regression test currently starts its 10-second timeout at process creation. That timeout includes child startup and imports, even though failure is reported as a reset_state() deadlock. Python 3.14 uses forkserver by default on POSIX, making this distinction more relevant.
This change adds a readiness signal immediately before reset_state(). Parent uses a separate startup timeout, then applies existing 10-second limit only to teardown. This preserves real deadlock detection and gives distinct failures for startup and teardown. Production code is unchanged.
Validation