Skip to content

Commit bcb3e70

Browse files
authored
Skip journal flush-trace loop when debug logging is disabled (#4835)
1 parent 6a4842e commit bcb3e70

1 file changed

Lines changed: 10 additions & 7 deletions

File tree

  • bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie

bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,14 +1151,17 @@ public void run() {
11511151
journalFlushWatcher.stop().elapsed(TimeUnit.NANOSECONDS), TimeUnit.NANOSECONDS);
11521152

11531153
// Trace the lifetime of entries through persistence
1154-
for (QueueEntry e : toFlush) {
1155-
if (e != null) {
1156-
log.debug()
1157-
.attr("ledgerId", e.ledgerId)
1158-
.attr("entryId", e.entryId)
1159-
.log("Written and queuing for flush");
1154+
RecyclableArrayList<QueueEntry> flushedEntries = toFlush;
1155+
log.debug(e -> {
1156+
for (QueueEntry entry : flushedEntries) {
1157+
if (entry != null) {
1158+
log.debug()
1159+
.attr("ledgerId", entry.ledgerId)
1160+
.attr("entryId", entry.entryId)
1161+
.log("Written and queuing for flush");
1162+
}
11601163
}
1161-
}
1164+
});
11621165

11631166
journalStats.getForceWriteBatchEntriesStats()
11641167
.registerSuccessfulValue(numEntriesToFlush);

0 commit comments

Comments
 (0)