Use -fno-access-control instead of -Dprivate=public for tests (#3346)

Replace the -Dprivate=public/-Dprotected=public macro hack with
-fno-access-control compiler flag in test builds. This avoids
redeclaration issues with standard library headers (e.g. <any>
under C++17) while still allowing tests to access private members.

Changes:
- test/CMakeLists.txt: replace -Dprivate=public with -fno-access-control
- test/Makefile: replace -Dprivate=public with -fno-access-control
- test/BUILD.bazel: remove sstream_workaround cc_library and all deps
- test/sstream_workaround.h: remove workaround (no longer needed)

Author: Felix-Gong

test/BUILD.bazel

@@ -143,13 +143,6 @@ brpc_proto_library(
     visibility = ["//visibility:public"],
 )
 
-cc_library(
-    name = "sstream_workaround",
-    hdrs = [
-        "sstream_workaround.h",
-    ],
-)
-
 cc_library(
     name = "gperftools_helper",
     hdrs = [
@@ -182,7 +175,6 @@ cc_test(
     defines = ["HAS_NLOHMANN_JSON=1"],
     deps = [
         ":cc_test_proto",
-        ":sstream_workaround",
         ":gperftools_helper",
         "//:butil",
         "//:bthread",
@@ -195,7 +187,6 @@ cc_test(
     name = "bvar_unittests",
     srcs = glob(["bvar_*_unittest.cpp"]),
     deps = [
-        ":sstream_workaround",
         ":gperftools_helper",
         "//:bvar",
         "@com_google_googletest//:gtest",
@@ -210,7 +201,6 @@ generate_unittests(
         "bthread*_unittest.cpp",
     ]),
     deps = [
-        ":sstream_workaround",
         ":gperftools_helper",
         "//:bthread",
         "@com_google_googletest//:gtest",
@@ -239,7 +229,6 @@ generate_unittests(
         "brpc_*_unittest.cpp",
     ]),
     deps = [
-        ":sstream_workaround",
         ":gperftools_helper",
         "//:brpc",
         ":cc_test_proto",

test/CMakeLists.txt

@@ -53,8 +53,8 @@ else()
 endif()
 
 set(CMAKE_CPP_FLAGS "${CMAKE_CPP_FLAGS} ${DEFINE_CLOCK_GETTIME} -DBRPC_WITH_GLOG=${WITH_GLOG_VAL} -DBRPC_WITH_RDMA=${WITH_RDMA_VAL}")
-set(CMAKE_CPP_FLAGS "${CMAKE_CPP_FLAGS} -DBTHREAD_USE_FAST_PTHREAD_MUTEX -D__const__=__unused__ -D_GNU_SOURCE -DUSE_SYMBOLIZE -DNO_TCMALLOC -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -DUNIT_TEST -Dprivate=public -Dprotected=public -DBVAR_NOT_LINK_DEFAULT_VARIABLES -D__STRICT_ANSI__ -include ${PROJECT_SOURCE_DIR}/test/sstream_workaround.h")
-set(CMAKE_CXX_FLAGS "${CMAKE_CPP_FLAGS} -g -O2 -pipe -Wall -W -fPIC -fstrict-aliasing -Wno-invalid-offsetof -Wno-unused-parameter -fno-omit-frame-pointer")
+set(CMAKE_CPP_FLAGS "${CMAKE_CPP_FLAGS} -DBTHREAD_USE_FAST_PTHREAD_MUTEX -D__const__=__unused__ -D_GNU_SOURCE -DUSE_SYMBOLIZE -DNO_TCMALLOC -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -DUNIT_TEST -DBVAR_NOT_LINK_DEFAULT_VARIABLES -D__STRICT_ANSI__")
+set(CMAKE_CXX_FLAGS "${CMAKE_CPP_FLAGS} -g -O2 -pipe -Wall -W -fPIC -fstrict-aliasing -Wno-invalid-offsetof -Wno-unused-parameter -fno-omit-frame-pointer -fno-access-control")
 use_cxx11()
 
 if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")

test/Makefile

@@ -18,8 +18,8 @@
 NEED_GPERFTOOLS=1
 NEED_GTEST=1
 include ../config.mk
-CPPFLAGS+=-DBTHREAD_USE_FAST_PTHREAD_MUTEX -D_GNU_SOURCE -DUSE_SYMBOLIZE -DNO_TCMALLOC -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -DUNIT_TEST -Dprivate=public -Dprotected=public -DBVAR_NOT_LINK_DEFAULT_VARIABLES --include sstream_workaround.h
-CXXFLAGS+=$(CPPFLAGS) -pipe -Wall -W -fPIC -fstrict-aliasing -Wno-invalid-offsetof -Wno-unused-parameter -fno-omit-frame-pointer -std=c++0x
+CPPFLAGS+=-DBTHREAD_USE_FAST_PTHREAD_MUTEX -D_GNU_SOURCE -DUSE_SYMBOLIZE -DNO_TCMALLOC -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -DUNIT_TEST -DBVAR_NOT_LINK_DEFAULT_VARIABLES
+CXXFLAGS+=$(CPPFLAGS) -pipe -Wall -W -fPIC -fstrict-aliasing -Wno-invalid-offsetof -Wno-unused-parameter -fno-omit-frame-pointer -fno-access-control -std=c++0x
 
 # On Darwin, only gtest library is needed, other libraries have been linked in `brpc.dbg.dylib`
 ifeq ($(SYSTEM),Darwin)