Skip to content

Commit 15b52c5

Browse files
authored
Remove Incorrect log in RemoveServersInBatch (#2932)
1 parent ab66887 commit 15b52c5

5 files changed

Lines changed: 0 additions & 15 deletions

src/brpc/policy/consistent_hashing_load_balancer.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,9 +267,6 @@ size_t ConsistentHashingLoadBalancer::RemoveServersInBatch(
267267
const size_t ret = _db_hash_ring.ModifyWithForeground(RemoveBatch, servers, &executed);
268268
CHECK(ret % _num_replicas == 0);
269269
const size_t n = ret / _num_replicas;
270-
LOG_IF(ERROR, n != servers.size())
271-
<< "Fail to RemoveServersInBatch, expected " << servers.size()
272-
<< " actually " << n;
273270
return n;
274271
}
275272

src/brpc/policy/dynpart_load_balancer.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,6 @@ size_t DynPartLoadBalancer::AddServersInBatch(
9595
size_t DynPartLoadBalancer::RemoveServersInBatch(
9696
const std::vector<ServerId>& servers) {
9797
const size_t n = _db_servers.Modify(BatchRemove, servers);
98-
LOG_IF(ERROR, n != servers.size())
99-
<< "Fail to RemoveServersInBatch, expected " << servers.size()
100-
<< " actually " << n;
10198
return n;
10299
}
103100

src/brpc/policy/randomized_load_balancer.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,6 @@ size_t RandomizedLoadBalancer::AddServersInBatch(
9797
size_t RandomizedLoadBalancer::RemoveServersInBatch(
9898
const std::vector<ServerId>& servers) {
9999
const size_t n = _db_servers.Modify(BatchRemove, servers);
100-
LOG_IF(ERROR, n != servers.size())
101-
<< "Fail to RemoveServersInBatch, expected " << servers.size()
102-
<< " actually " << n;
103100
return n;
104101
}
105102

src/brpc/policy/round_robin_load_balancer.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,6 @@ size_t RoundRobinLoadBalancer::AddServersInBatch(
9797
size_t RoundRobinLoadBalancer::RemoveServersInBatch(
9898
const std::vector<ServerId>& servers) {
9999
const size_t n = _db_servers.Modify(BatchRemove, servers);
100-
LOG_IF(ERROR, n != servers.size())
101-
<< "Fail to RemoveServersInBatch, expected " << servers.size()
102-
<< " actually " << n;
103100
return n;
104101
}
105102

src/brpc/policy/weighted_round_robin_load_balancer.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,6 @@ size_t WeightedRoundRobinLoadBalancer::AddServersInBatch(
150150
size_t WeightedRoundRobinLoadBalancer::RemoveServersInBatch(
151151
const std::vector<ServerId>& servers) {
152152
const size_t n = _db_servers.Modify(BatchRemove, servers);
153-
LOG_IF(ERROR, n != servers.size())
154-
<< "Fail to RemoveServersInBatch, expected " << servers.size()
155-
<< " actually " << n;
156153
return n;
157154
}
158155

0 commit comments

Comments
 (0)