Support higher performance bvar with babylon counter (#3116)

* Support higher performance bvar with babylon counter

* Update documents

Author: chenBright

.bazelrc

@@ -20,6 +20,7 @@ common --registry=https://bcr.bazel.build
 common --registry=https://baidu.github.io/babylon/registry
 
 build --cxxopt="-std=c++17"
+build --copt="-fno-omit-frame-pointer"
 # Use gnu17 for asm keyword.
 build --conlyopt="-std=gnu17"
 
@@ -33,8 +34,8 @@ build --features=per_object_debug_info
 build --define absl=1
 
 # For brpc.
-build --define=BRPC_WITH_GLOG=true
 test --define=BRPC_BUILD_FOR_UNITTEST=true
+test --test_output=streamed
 
 # Pass PATH, CC, CXX and LLVM_CONFIG variables from the environment.
 build --action_env=CC

.github/pull_request_template.md

@@ -1,6 +1,6 @@
 ### What problem does this PR solve?
 
-Issue Number:
+Issue Number: resolve 
 
 Problem Summary:
 

.github/workflows/ci-linux.yml

@@ -225,3 +225,12 @@ jobs:
       run: |
         cd test
         sh ./run_tests.sh
+
+  bazel-bvar-unittest:
+    runs-on: ubuntu-22.04
+    steps:
+    - uses: actions/checkout@v2
+    - run: bazel test --verbose_failures //test:bvar_test
+    - run: bazel test --verbose_failures --define with_babylon_counter=true //test:bvar_test
+    - run: bazel test --verbose_failures --action_env=CC=clang //test:bvar_test
+    - run: bazel test --verbose_failures --action_env=CC=clang --define with_babylon_counter=true //test:bvar_test

.github/workflows/ci-macos.yml

@@ -61,7 +61,6 @@ jobs:
 
   compile-with-bazel:
     runs-on: macos-latest # https://github.com/actions/runner-images
-
     steps:
       - uses: actions/checkout@v2
       - run: bazel build --verbose_failures -- //:brpc -//example/...

BUILD.bazel

@@ -21,6 +21,7 @@ licenses(["notice"])  # Apache v2
 exports_files(["LICENSE"])
 
 COPTS = [
+    "-fno-omit-frame-pointer",
     "-DBTHREAD_USE_FAST_PTHREAD_MUTEX",
     "-D__const__=__unused__",
     "-D_GNU_SOURCE",
@@ -377,6 +378,10 @@ cc_library(
         "src/bvar/utils/*.h",
         "src/bvar/detail/*.h",
     ]),
+    defines = [] + select({
+        "//bazel/config:with_babylon_counter": ["WITH_BABYLON_COUNTER=1"],
+        "//conditions:default": [],
+    }),
     copts = COPTS + select({
         "//bazel/config:brpc_build_for_unittest": [
             "-DBVAR_NOT_LINK_DEFAULT_VARIABLES",
@@ -391,7 +396,10 @@ cc_library(
     visibility = ["//visibility:public"],
     deps = [
         ":butil",
-    ],
+    ]  + select({
+        "//bazel/config:with_babylon_counter": ["@babylon//:concurrent_counter"],
+        "//conditions:default": [],
+    }),
 )
 
 cc_library(

MODULE.bazel

@@ -17,6 +17,7 @@ bazel_dep(name = 'rules_cc', version = '0.0.1')
 bazel_dep(name = 'rules_proto', version = '4.0.0')
 bazel_dep(name = 'zlib', version = '1.3.1.bcr.5', repo_name = 'com_github_madler_zlib')
 bazel_dep(name = 'libunwind', version = '1.8.1', repo_name = 'com_github_libunwind_libunwind')
+bazel_dep(name = 'babylon', version = '1.4.4')
 
 # --registry=https://baidu.github.io/babylon/registry
 bazel_dep(name = 'leveldb', version = '1.23', repo_name = 'com_github_google_leveldb')

bazel/config/BUILD.bazel

@@ -142,4 +142,10 @@ config_setting(
     name = "brpc_with_no_pthread_mutex_hook",
     define_values = {"BRPC_WITH_NO_PTHREAD_MUTEX_HOOK": "true"},
     visibility = ["//visibility:public"],
+)
+
+config_setting(
+    name = "with_babylon_counter",
+    define_values = {"with_babylon_counter": "true"},
+    visibility = ["//visibility:public"],
 )

docs/cn/bvar_c++.md

@@ -650,3 +650,9 @@ static bvar::GFlag s_gflag_my_flag_that_matters("my_flag_that_matters");
 // Expose the gflag as a bvar named "foo_bar_my_flag_that_matters".
 static bvar::GFlag s_gflag_my_flag_that_matters_with_prefix("foo_bar", "my_flag_that_matters");
 ```
+# babylon counter bvar
+
+原理和性能见[babylon介绍](https://github.com/baidu/babylon/tree/main/example/use-counter-with-bvar)。
+
+目前只支持bazel编译方式：`--define with_babylon_counter=true`，babylon版本要求：>= 1.4.4。打开开关后，即可使用基于babylon counter实现的更高性能的bvar，无需修改代码。
+

docs/en/bvar_c++.md

@@ -490,3 +490,9 @@ static bvar::GFlag s_gflag_my_flag_that_matters("my_flag_that_matters");
 // Expose the gflag as a bvar named "foo_bar_my_flag_that_matters".
 static bvar::GFlag s_gflag_my_flag_that_matters_with_prefix("foo_bar", "my_flag_that_matters");
 ```
+
+# babylon counter bvar
+
+For details on the principles and performance, see [Use concurrent counter optimize bvar](https://github.com/baidu/babylon/tree/main/example/use-counter-with-bvar).
+
+Currently, this feature is only supported by the Bazel compilation method: `--define with_babylon_counter=true`. The required Babylon version is 1.4.4 or higher. Once enabled, you can use the higher-performance bvar implementation based on the babylon counter without modifying your code.

src/butil/macros.h

@@ -44,11 +44,11 @@
 
 // Declarations for a class to be unassignable.
 #define DISALLOW_ASSIGN(TypeName)                        \
-    BUTIL_DELETE_FUNCTION(void operator=(const TypeName&))
+    BUTIL_DELETE_FUNCTION(TypeName& operator=(const TypeName&))
 
 // Declarations for a class to be move-unassignable.
 #define DISALLOW_MOVE_ASSIGN(TypeName)                   \
-    BUTIL_DELETE_FUNCTION(void operator=(TypeName&&))
+    BUTIL_DELETE_FUNCTION(TypeName& operator=(TypeName&&))
 
 // A macro to disallow the copy constructor and operator= functions.
 #define DISALLOW_COPY_AND_ASSIGN(TypeName)               \