Skip to content

Commit 5fdb0d8

Browse files
authored
Remove unused comp channel (#3279)
1 parent b5dc6fc commit 5fdb0d8

3 files changed

Lines changed: 13 additions & 10 deletions

File tree

src/brpc/rdma/rdma_helper.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,6 @@ static void GlobalRdmaInitializeOrDieImpl() {
505505
} else {
506506
LOG(INFO) << "RDMA GID Index: " << (int)g_gid_index;
507507
}
508-
IbvCreateCompChannel(g_context);
509508

510509
// Create protection domain
511510
g_pd = IbvAllocPd(g_context);

src/brpc/socket.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2512,8 +2512,12 @@ void Socket::DebugSocket(std::ostream& os, SocketId id) {
25122512
<< "\n}";
25132513
}
25142514
#endif
2515+
2516+
os << "\nrdma={\n";
25152517
ptr->_transport->Debug(os);
2516-
{ os << "\nbthread_tag=" << ptr->_io_event.bthread_tag(); }
2518+
os << "}\n";
2519+
2520+
os << "\nbthread_tag=" << ptr->_io_event.bthread_tag();
25172521
}
25182522

25192523
int Socket::CheckHealth() {

test/bvar_recorder_unittest.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -244,15 +244,15 @@ TEST(RecorderTest, latency_recorder_qps_accuracy) {
244244
double err = fabs(qps_sum / 1000.0 - exp_qps);
245245
return err;
246246
};
247-
ASSERT_GT(0.2, read(lr1, 10/2.0));
248-
ASSERT_GT(0.2, read(lr2, 11/2.0));
249-
ASSERT_GT(0.2, read(lr3, 3/2.0));
250-
ASSERT_GT(0.2, read(lr4, 1/2.0));
247+
ASSERT_GT(0.1, read(lr1, 10/2.0));
248+
ASSERT_GT(0.1, read(lr2, 11/2.0));
249+
ASSERT_GT(0.1, read(lr3, 3/2.0));
250+
ASSERT_GT(0.1, read(lr4, 1/2.0));
251251

252-
ASSERT_GT(0.2, read(lr1, 10/3.0, 3));
253-
ASSERT_GT(0.2, read(lr2, 11/3.0, 3));
254-
ASSERT_GT(0.2, read(lr3, 3/3.0, 3));
255-
ASSERT_GT(0.2, read(lr4, 1/3.0, 3));
252+
ASSERT_GT(0.1, read(lr1, 10/3.0, 3));
253+
ASSERT_GT(0.1, read(lr2, 11/3.0, 3));
254+
ASSERT_GT(0.1, read(lr3, 3/3.0, 3));
255+
ASSERT_GT(0.1, read(lr4, 1/3.0, 3));
256256
}
257257

258258
} // namespace

0 commit comments

Comments
 (0)