Skip to content

Commit b223e60

Browse files
authored
Fix RDMA resource (#3269)
1 parent 12fb539 commit b223e60

2 files changed

Lines changed: 17 additions & 0 deletions

File tree

src/brpc/rdma/rdma_endpoint.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1200,6 +1200,7 @@ int RdmaEndpoint::AllocateResources() {
12001200
options.on_edge_triggered_events = PollCq;
12011201
if (Socket::Create(options, &_cq_sid) < 0) {
12021202
PLOG(WARNING) << "Fail to create socket for cq";
1203+
return -1;
12031204
}
12041205
} else {
12051206
SocketOptions options;

test/bvar_variable_unittest.cpp

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,18 @@ TEST_F(VariableTest, latency_recorder) {
324324
ASSERT_EQ(-1, rec.expose("latency"));
325325
ASSERT_EQ(-1, rec.expose("Latency"));
326326

327+
std::string saved_bvar_latency_p1;
328+
std::string saved_bvar_latency_p2;
329+
std::string saved_bvar_latency_p3;
330+
331+
GFLAGS_NAMESPACE::GetCommandLineOption("bvar_latency_p1", &saved_bvar_latency_p1);
332+
GFLAGS_NAMESPACE::GetCommandLineOption("bvar_latency_p2", &saved_bvar_latency_p2);
333+
GFLAGS_NAMESPACE::GetCommandLineOption("bvar_latency_p3", &saved_bvar_latency_p3);
334+
335+
GFLAGS_NAMESPACE::SetCommandLineOption("bvar_latency_p1", "80");
336+
GFLAGS_NAMESPACE::SetCommandLineOption("bvar_latency_p2", "90");
337+
GFLAGS_NAMESPACE::SetCommandLineOption("bvar_latency_p3", "99");
338+
327339

328340
ASSERT_EQ(0, rec.expose("FooBar__latency"));
329341
std::vector<std::string> names;
@@ -373,6 +385,10 @@ TEST_F(VariableTest, latency_recorder) {
373385
ASSERT_EQ("ba_na_na_latency_percentiles", names[8]);
374386
ASSERT_EQ("ba_na_na_max_latency", names[9]);
375387
ASSERT_EQ("ba_na_na_qps", names[10]);
388+
389+
GFLAGS_NAMESPACE::SetCommandLineOption("bvar_latency_p1", saved_bvar_latency_p1.c_str());
390+
GFLAGS_NAMESPACE::SetCommandLineOption("bvar_latency_p2", saved_bvar_latency_p2.c_str());
391+
GFLAGS_NAMESPACE::SetCommandLineOption("bvar_latency_p3", saved_bvar_latency_p3.c_str());
376392
}
377393

378394
TEST_F(VariableTest, recursive_mutex) {

0 commit comments

Comments
 (0)