set default behaviour for bthread_cond_signal to no signal (#7)

Author: MrGuin

src/bthread/bthread.h

@@ -196,11 +196,8 @@ extern int bthread_cond_init(bthread_cond_t* __restrict cond,
 // Destroy condition variable `cond'.
 extern int bthread_cond_destroy(bthread_cond_t* cond);
 
-#ifndef BTHREAD_COND_SIGNAL
-#define BTHREAD_COND_SIGNAL
 // Wake up one thread waiting for condition variable `cond'.
-extern int bthread_cond_signal(bthread_cond_t* cond, bool no_signal = false);
-#endif
+extern int bthread_cond_signal(bthread_cond_t* cond);
 
 // Wake up all threads waiting for condition variables `cond'.
 extern int bthread_cond_broadcast(bthread_cond_t* cond);

src/bthread/condition_variable.cpp

@@ -58,13 +58,14 @@ int bthread_cond_destroy(bthread_cond_t* c) {
     return 0;
 }
 
-int bthread_cond_signal(bthread_cond_t* c, bool no_signal) {
+int bthread_cond_signal(bthread_cond_t* c) {
     bthread::CondInternal* ic = reinterpret_cast<bthread::CondInternal*>(c);
     // ic is probably dereferenced after fetch_add, save required fields before
     // this point
     butil::atomic<int>* const saved_seq = ic->seq;
     saved_seq->fetch_add(1, butil::memory_order_release);
     // don't touch ic any more
+    bool no_signal = true;
     bthread::butex_wake(saved_seq, no_signal);
     return 0;
 }

src/bthread/condition_variable.h

@@ -29,10 +29,7 @@ __BEGIN_DECLS
 extern int bthread_cond_init(bthread_cond_t* __restrict cond,
                              const bthread_condattr_t* __restrict cond_attr);
 extern int bthread_cond_destroy(bthread_cond_t* cond);
-#ifndef BTHREAD_COND_SIGNAL
-#define BTHREAD_COND_SIGNAL
-extern int bthread_cond_signal(bthread_cond_t* cond, bool no_signal = false);
-#endif
+extern int bthread_cond_signal(bthread_cond_t* cond);
 extern int bthread_cond_broadcast(bthread_cond_t* cond);
 extern int bthread_cond_wait(bthread_cond_t* __restrict cond,
                              bthread_mutex_t* __restrict mutex);
@@ -92,8 +89,8 @@ class ConditionVariable {
         return rc == ETIMEDOUT ? ETIMEDOUT : 0;
     }
 
-    void notify_one(bool no_signal = false) {
-        bthread_cond_signal(&_cond, no_signal);
+    void notify_one() {
+        bthread_cond_signal(&_cond);
     }
 
     void notify_all() {